-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Web Validator Client Display Errors #1383
Conversation
* refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <[email protected]>
* Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator.
✅ Rule acceptance tests passed. |
✅ Rule acceptance tests passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Looks like we can merge this one after this suggestion is solved! cc @KClough |
✅ Rule acceptance tests passed. |
* chore: fix deprecated dependency * chore: auto-format * feat: handle missing RULES.md * feat: refactor upload process and handle more errors * Add a more descriptive test failure message to NoticeFieldsTest. (MobilityData#1369) * Docs: Update notice migration file (MobilityData#1357) * refactor migration file * update documentation with new file * fix wording * Make easier to read * remove colors --------- Co-authored-by: Emma Blue <[email protected]> * feat: Fail acceptance tests on significant change in warnings (MobilityData#1377) * Refactor logic out of of outputcomparator/cli/Main and into a new ValidationReportComparator class for easier testing. In addition, update ValidationReportComparator to trigger a comparison error if changed warnings are above configured thresholds. * Additional unit tests for ValidationReportComparator. --------- Co-authored-by: Ryon Coleman <[email protected]> Co-authored-by: Brian Ferris <[email protected]> Co-authored-by: isabelle-dr <[email protected]> Co-authored-by: Emma Blue <[email protected]> Co-authored-by: David Gamez <[email protected]>
Summary
Expected behavior
Failed to get a job ID from the server
Failed to PUT the file
Failed to check for a report (other than expected 404 while waiting)
Failed to fetch local RULES.md
Checklist
gradle test
to make sure you didn't break anythingNotes
This branch is based on https://github.com/MobilityData/gtfs-validator/tree/master which used to be thefeat/web
branch in the Jarvus fork, hence all the extra commits.