ci: include multiple versions of java and OS in test_pack_dock workflow #1093

lionel-nj · 2022-02-01T14:31:30Z

Summary:

This PR provides support to execute test_pack_doc.yml workflow on multiple versions of Java: 11 and 17, as well as different OS; in order to flag potential incompatibilities.

Expected behavior:

Run the same jobs test, doc, and pack on different versions of the JDK: 11 and 17.

All artifacts should be persisted and identified by the JDK's and OS version that was used to produce them.

Please make sure these boxes are checked before submitting your pull request - thanks!

Run the unit tests with gradle test to make sure you didn't break anything
Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
Linked all relevant issues
Include screenshot(s) showing how this pull request works and fixes the issue(s)

github-actions · 2022-02-01T15:22:55Z

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit 6e04670 here (report will disappear after 90 days).

lionel-nj · 2022-02-01T17:56:50Z

@ed-g I'd like to add to add the OS you're using to the list of OS to be run. You mentioned Linux x86 earlier, could you give information about the distribution that is used on your side please?

List of supported runners by Github Actions

barbeau · 2022-02-01T20:17:44Z

.github/workflows/test_pack_doc.yml

@@ -110,11 +116,14 @@ jobs:
      - name: Persist cli app jar
        uses: actions/upload-artifact@v2
        with:
-          name: Application - cli executable .jar -- ${{ steps.prep.outputs.versionTag }}
+          name: Application - cli executable - Java ${{ matrix.java_version }}.jar -- ${{ steps.prep.outputs.versionTag }}


IMHO this is difficult to read as a name, and it's already hard to find the right Action when looking at "checks" output (see #1095 for a more general discussion of this).

Here's an alternative that I think is easier to read:

Suggested change

name: Application - cli executable - Java ${{ matrix.java_version }}.jar -- ${{ steps.prep.outputs.versionTag }}

name: Application - CLI executable - Java ${{ matrix.java_version }} JAR file -- ${{ steps.prep.outputs.versionTag }}

.github/workflows/test_pack_doc.yml

ed-g · 2022-02-02T20:40:19Z

@ed-g I'd like to add to add the OS you're using to the list of OS to be run. You mentioned Linux x86 earlier, could you give information about the distribution that is used on your side please?

You bet, it's centos stream 8 (redhat workalike) here's the version from the server;

uname
Linux v 4.18.0-358.el8.x86_64 #1 SMP x86_64 x86_64 GNU/Linux

redhat-release
CentOS Stream release 8

java packages

java-17-openjdk-headless-17.0.1.0.12-2.el8_5.x86_64
java-17-openjdk-17.0.1.0.12-2.el8_5.x86_64
java-17-openjdk-devel-17.0.1.0.12-2.el8_5.x86_64

ed-g · 2022-02-02T22:25:45Z

"Ubuntu 20.04" is probably the nearest.

This reverts commit 9a068e8.

lionel-nj · 2022-02-04T15:00:14Z

It seems that the generation of javadocs on window-latest is problematic due to use of emojis in Strings. I opened #1101 to document this for future work.

As of now, doc job of test_pack_doc workflow is only executed on ubuntu-latest and ubuntu-20.04. After this PR is merge we will potentially be able to replicate the bug regarding unit tests in output-comparator from #1086 (comment).

github-actions · 2022-02-04T15:25:54Z

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit 0690b20 here (report will disappear after 90 days).

barbeau · 2022-04-19T22:07:31Z

Hopefully Windows Javadoc generation should work correctly after PR #1121 is merged, which should unblock this PR.

This was fixed in #1121

github-actions · 2022-04-20T16:37:35Z

Thank you for this contribution! 🍰✨🦄

Information about source corruption

0 out of 1248 sources are corrupted.

Acceptance test details

The changes in this pull request did not trigger any new errors on known GTFS datasets from the MobilityDatabase.
Download the full acceptance test report for commit dbb5602 here (report will disappear after 90 days).

barbeau

@maximearmstrong Do you have any objection to merging this? It seems to be working as intended to me - package/test/javadoc tasks are run across Linux and Windows on GitHub CI now, for both Java 11 and 17.

maximearmstrong · 2022-04-20T20:41:12Z

@barbeau All good on my side! Thank you!

try multiple versions of java in CI

5943e12

lionel-nj changed the title ~~CI: include multiple versions of java in CI~~ ci: include multiple versions of java in CI Feb 1, 2022

lionel-nj added 2 commits February 1, 2022 10:35

additional information regarding the version used

51bf4e3

same thing with pack and doc jobs

87b2aec

lionel-nj requested review from barbeau and maximearmstrong February 1, 2022 14:46

lionel-nj changed the title ~~ci: include multiple versions of java in CI~~ ci: include multiple versions of java in test_pack_dock workflow Feb 1, 2022

lionel-nj marked this pull request as ready for review February 1, 2022 14:48

lionel-nj self-assigned this Feb 1, 2022

Merge branch 'master' into ci/multiple-java-versions

61e7cd7

lionel-nj marked this pull request as draft February 1, 2022 17:57

lionel-nj changed the title ~~ci: include multiple versions of java in test_pack_dock workflow~~ ci: include multiple versions of java and OS in test_pack_dock workflow Feb 1, 2022

barbeau mentioned this pull request Feb 1, 2022

Better organize/name GitHub Action "checks" output #1095

Open

barbeau reviewed Feb 1, 2022

View reviewed changes

lionel-nj added 12 commits February 3, 2022 19:01

additional OS

221b8b0

additional OS only on test job

ddcc938

remove duplicate job prep

52cf86c

run on multiple OS on pack and doc jobs

caa7918

additional OS on package job

f5e93ee

persist artifacts for all OS used

81a766b

compileTestJava

4b6d227

use code instead of emoji

9a068e8

do not use compileTestJava

387036c

Revert "use code instead of emoji"

9caca88

This reverts commit 9a068e8.

do not run doc job on window-latest for now

b72b77c

fix syntax

e2cca85

MobilityData deleted a comment from github-actions bot Feb 4, 2022

rename task and specify prepare-version-name in needs

06a7ca9

lionel-nj added 2 commits February 8, 2022 12:07

add instructions for encoding while generating the javadocs

79ca93d

run doc job on windows-latest

59858fa

barbeau mentioned this pull request Apr 19, 2022

fix: Set encoding to UTF-8 for Javadoc generation #1121

Merged

4 tasks

barbeau added 2 commits April 20, 2022 12:14

chore: Remove extra Javadoc config

b34bbe1

This was fixed in #1121

Merge branch 'master' into ci/multiple-java-versions

4d62d96

barbeau marked this pull request as ready for review April 20, 2022 19:34

barbeau approved these changes Apr 20, 2022

View reviewed changes

maximearmstrong merged commit 19b0cb3 into master Apr 20, 2022

maximearmstrong deleted the ci/multiple-java-versions branch April 20, 2022 20:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ci: include multiple versions of java and OS in test_pack_dock workflow #1093

ci: include multiple versions of java and OS in test_pack_dock workflow #1093

lionel-nj commented Feb 1, 2022 •

edited

Loading

github-actions bot commented Feb 1, 2022

lionel-nj commented Feb 1, 2022 •

edited

Loading

barbeau Feb 1, 2022

ed-g commented Feb 2, 2022

ed-g commented Feb 2, 2022

lionel-nj commented Feb 4, 2022 •

edited

Loading

github-actions bot commented Feb 4, 2022

barbeau commented Apr 19, 2022

github-actions bot commented Apr 20, 2022

barbeau left a comment

maximearmstrong commented Apr 20, 2022

	name: Application - cli executable - Java ${{ matrix.java_version }}.jar -- ${{ steps.prep.outputs.versionTag }}
	name: Application - CLI executable - Java ${{ matrix.java_version }} JAR file -- ${{ steps.prep.outputs.versionTag }}

ci: include multiple versions of java and OS in test_pack_dock workflow #1093

ci: include multiple versions of java and OS in test_pack_dock workflow #1093

Conversation

lionel-nj commented Feb 1, 2022 • edited Loading

github-actions bot commented Feb 1, 2022

Information about source corruption

Acceptance test details

lionel-nj commented Feb 1, 2022 • edited Loading

barbeau Feb 1, 2022

Choose a reason for hiding this comment

ed-g commented Feb 2, 2022

ed-g commented Feb 2, 2022

lionel-nj commented Feb 4, 2022 • edited Loading

github-actions bot commented Feb 4, 2022

Information about source corruption

Acceptance test details

barbeau commented Apr 19, 2022

github-actions bot commented Apr 20, 2022

Information about source corruption

Acceptance test details

barbeau left a comment

Choose a reason for hiding this comment

maximearmstrong commented Apr 20, 2022

lionel-nj commented Feb 1, 2022 •

edited

Loading

lionel-nj commented Feb 1, 2022 •

edited

Loading

lionel-nj commented Feb 4, 2022 •

edited

Loading