Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: upgrade TranslationForeignKeyViolationNotice to ERROR #1027

Merged
merged 1 commit into from
Nov 4, 2021
Merged

chore: upgrade TranslationForeignKeyViolationNotice to ERROR #1027

merged 1 commit into from
Nov 4, 2021

Conversation

lionel-nj
Copy link
Contributor

@lionel-nj lionel-nj commented Oct 5, 2021 •
edited
Loading

closes #1026

Summary:

This PR provides support to update TranslationForeignKeyViolationNotice : from WARNING to ERROR.

Expected behavior:

According to the specification:

The value in record_id must be a main ID of the table

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • [ ] Include screenshot(s) showing how this pull request works and fixes the issue(s)

@lionel-nj lionel-nj self-assigned this Oct 5, 2021
@isabelle-dr isabelle-dr added the GTFS Reference Used for Adding or changing rules that belong in the GTFS reference label Oct 20, 2021
@isabelle-dr
Copy link
Contributor

This notice isn't emitted by any datasets from the Mobility Database currently.

@isabelle-dr isabelle-dr added this to the v3.0.0 milestone Oct 27, 2021
lionel-nj pushed a commit that referenced this pull request Oct 28, 2021
assess changes introduced by #1022, #1028 and #1027
8747c6f
asvechnikov2
asvechnikov2 approved these changes Nov 4, 2021
View reviewed changes
Copy link
Collaborator

@asvechnikov2 asvechnikov2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lionel-nj lionel-nj merged commit ddd99ca into master Nov 4, 2021
@lionel-nj lionel-nj deleted the task/change-severity-TranslationForeignKeyViolationNotice branch November 4, 2021 13:04
This was referenced Nov 5, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvechnikov2 asvechnikov2 asvechnikov2 approved these changes

@aababilov aababilov Awaiting requested review from aababilov

@barbeau barbeau Awaiting requested review from barbeau

Assignees

@lionel-nj lionel-nj

Labels
GTFS Reference Used for Adding or changing rules that belong in the GTFS reference
Projects
None yet
Milestone
v3.0.0 - acceptance test v0
Development

Successfully merging this pull request may close these issues.

Upgrade TranslationForeignKeyViolationNotice to ERROR
3 participants
@lionel-nj @isabelle-dr @asvechnikov2