Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate uniqueness of values in Arrays of IDs #159

Closed
wants to merge 1 commit into from

Conversation

richfab
Copy link
Contributor

@richfab richfab commented Nov 22, 2023

JSON Schema sync after MobilityData/gbfs-json-schema#102

Example of vehicle_types.json file with with duplicate ids in the field vehicle_types.pricing_plan_ids:

"pricing_plan_ids": ["1-standard", "1-standard"]
Before After
image image

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for gbfs-validator ready!

Name Link
🔨 Latest commit d4ad2e2
🔍 Latest deploy log https://app.netlify.com/sites/gbfs-validator/deploys/655e341d5932c20008a31679
😎 Deploy Preview https://deploy-preview-159--gbfs-validator.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@richfab
Copy link
Contributor Author

richfab commented Nov 22, 2023

The JSON Schema change was reverted in MobilityData/gbfs-json-schema#104 since this is a best practice, not explicitly written in the specs.

Closing this PR for now.

@richfab richfab closed this Nov 22, 2023
@richfab richfab deleted the feat/unique-values-in-arrays-of-ids branch November 22, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant