Add v3.0-RC2 support #157
Merged
Add v3.0-RC2 support #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for gbfs-validator ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
LGTM |
testower
reviewed
Nov 16, 2023
gbfs-validator/versions/partials/v3.0-RC2/system_information/required_store_uri.js
Outdated
Show resolved
Hide resolved
testower
reviewed
Nov 16, 2023
gbfs-validator/versions/partials/v3.0-RC2/vehicle_status/required_vehicle_type_id.js
Outdated
Show resolved
Hide resolved
testower
suggested changes
Nov 16, 2023
tdelmas
approved these changes
Nov 16, 2023
josee-sabourin
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds v3.0-RC2 support in the GBFS validator.
I chose to replace the v3.0-RC tests with v3.0-RC2 tests as the v3.0-RC2 changes includes the v3.0-RC changes.
A thorough review would be appreciated as this is my first version update contribution to the validator. Thank you!