Skip to content

Add option to only transfer units if they are newer#52

Merged
brentleyjones merged 1 commit intomasterfrom
bj/only-transfer-units-if-they-are-newer
Jan 25, 2021
Merged

Add option to only transfer units if they are newer#52
brentleyjones merged 1 commit intomasterfrom
bj/only-transfer-units-if-they-are-newer

Conversation

@brentleyjones
Copy link
Contributor

@brentleyjones brentleyjones commented Jan 22, 2021

An alternative implementation of #32.

Closes #32.

@brentleyjones brentleyjones force-pushed the bj/only-transfer-units-if-they-are-newer branch from f044dad to 0ead573 Compare January 22, 2021 18:44
@brentleyjones brentleyjones force-pushed the bj/only-transfer-units-if-they-are-newer branch from 0ead573 to ae548f8 Compare January 22, 2021 18:46
@brentleyjones
Copy link
Contributor Author

See #46 for discussion of this change. Added the flag to make this opt-in.

@brentleyjones brentleyjones changed the title Only transfer units if they are newer Add option to only transfer units if they are newer Jan 22, 2021
@brentleyjones
Copy link
Contributor Author

For at least one test case this brought a 5.9 second import down to 1.2 seconds.

@brentleyjones brentleyjones requested a review from keith January 22, 2021 18:47
@brentleyjones brentleyjones marked this pull request as ready for review January 22, 2021 18:47
@brentleyjones brentleyjones merged commit 44fbe01 into master Jan 25, 2021
@brentleyjones brentleyjones deleted the bj/only-transfer-units-if-they-are-newer branch January 25, 2021 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants