Skip to content

Conversation

@chris-mitchell
Copy link
Collaborator

The PR #289 didn't seem to run on CI and missed some checks.

Two main issues were introduced:

This reverts only the appropriate pieces and leaves most of the changes in place.

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #305 (0502d03) into main (555fe5d) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 0502d03 differs from pull request most recent head 3cf66e2. Consider uploading reports for the commit 3cf66e2 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main     #305      +/-   ##
============================================
+ Coverage     85.33%   85.36%   +0.02%     
+ Complexity      180      178       -2     
============================================
  Files            49       49              
  Lines           914      909       -5     
  Branches        126      126              
============================================
- Hits            780      776       -4     
+ Misses           77       76       -1     
  Partials         57       57              
Impacted Files Coverage Δ
...va/com/dropbox/android/external/fs3/FSAllReader.kt 100.00% <ø> (ø)
...dropbox/android/external/fs3/SourceAllPersister.kt 0.00% <ø> (ø)
...box/android/external/fs3/SourcePersisterFactory.kt 0.00% <ø> (ø)
...otlin/com/dropbox/flow/multicast/ChannelManager.kt 89.06% <ø> (ø)
...n/kotlin/com/dropbox/flow/multicast/Multicaster.kt 96.96% <ø> (-0.09%) ⬇️
...2/src/main/kotlin/com/dropbox/store/rx2/RxStore.kt 100.00% <ø> (ø)
...ain/kotlin/com/dropbox/store/rx2/RxStoreBuilder.kt 100.00% <ø> (ø)
...3/src/main/kotlin/com/dropbox/store/rx3/RxStore.kt 100.00% <ø> (ø)
...ain/kotlin/com/dropbox/store/rx3/RxStoreBuilder.kt 100.00% <ø> (ø)
...om/dropbox/android/external/store4/StoreBuilder.kt 100.00% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b8cb0...3cf66e2. Read the comment docs.

@chris-mitchell chris-mitchell merged commit 862da9b into MobileNativeFoundation:main Sep 9, 2021
@chris-mitchell chris-mitchell deleted the fixMissingExperimentalAnnotations branch September 9, 2021 15:46
itsandreramon pushed a commit to itsandreramon/Store that referenced this pull request Feb 26, 2025
* Revert "Remove unnecessary FlowPreview & ExperimentalCoroutinesApi annotations.  These are not needed with newer versions of Kotlin. (MobileNativeFoundation#289)"

This reverts commit 61b8cb0.

* Fix missing experimental annotations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants