Resolve Memory Leak #198
Closed
Resolve Memory Leak #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keyword from RefCountedResource’s create lambda, to prevent it from capture by FetcherController’s onEach()
digitalbuddha
approved these changes
Aug 5, 2020
Contributor
digitalbuddha
left a comment
digitalbuddha
left a comment
There was a problem hiding this comment.
Looks like we need leak canary on our sample. I'll do that as a follow up
Contributor
|
hold on on this going with an alternative approach |
steve-the-edwards
approved these changes
Aug 5, 2020
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Legwork by Zach in (#197)
Resolve memory leak by removing suspend keyword from RefCountedResource’s create lambda, to prevent it from capture by FetcherController’s onEach()