Skip to content

Conversation

@ychescale9
Copy link
Contributor

@ychescale9 ychescale9 commented Jul 29, 2020

I ran into the same Duration issue after updating Kotlin to 1.4.0-rc so here's a PR to update Store to compile with kotlin 1.4.0-rc and revert @chrisbanes 's workaround (tested snapshot artifact locally).

Also fixed a bunch of type inference issues raised by the new compiler.

Update: just updated to kotlin 1.4.0 and Coroutines 1.3.9.

@codecov
Copy link

codecov bot commented Jul 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (main@ecc3470). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage        ?   84.16%           
  Complexity      ?      233           
=======================================
  Files           ?       54           
  Lines           ?      998           
  Branches        ?      168           
=======================================
  Hits            ?      840           
  Misses          ?       85           
  Partials        ?       73           
Impacted Files Coverage Δ Complexity Δ
...d/external/store4/impl/SourceOfTruthWithBarrier.kt 86.04% <ø> (ø) 7.00 <0.00> (?)
...otlin/com/dropbox/android/external/cache4/Cache.kt 100.00% <100.00%> (ø) 0.00 <0.00> (?)
...n/kotlin/com/dropbox/flow/multicast/Multicaster.kt 96.66% <100.00%> (ø) 8.00 <0.00> (?)
.../dropbox/android/external/store4/impl/RealStore.kt 94.64% <100.00%> (ø) 16.00 <0.00> (?)
...droid/external/store4/impl/operators/MapIndexed.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...otlin/com/dropbox/android/external/cache4/Clock.kt 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...m/dropbox/android/external/fs3/SourceFileWriter.kt 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
.../android/external/fs3/filesystem/FileSystemImpl.kt 95.12% <0.00%> (ø) 16.00% <0.00%> (?%)
...droid/external/fs3/filesystem/FileSystemFactory.kt 100.00% <0.00%> (ø) 2.00% <0.00%> (?%)
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecc3470...17c43e1. Read the comment docs.

@eyalgu
Copy link
Contributor

eyalgu commented Jul 31, 2020

As we're approaching beta, I think we'd probably avoid targeting an rc release and wait till the official 1.4 release.

@ychescale9 ychescale9 changed the title Update to Kotlin 1.4.0-rc and revert to using Duration.INFINITE Update to Kotlin 1.4.0, Coroutines 1.3.9 and revert to using Duration.INFINITE Aug 14, 2020
@digitalbuddha digitalbuddha merged commit a0477c1 into MobileNativeFoundation:main Aug 14, 2020
eyalgu added a commit that referenced this pull request Sep 8, 2020
rallat pushed a commit that referenced this pull request Aug 13, 2021
….INFINITE (#195)

* Update to Kotlin 1.4.0-rc and Coroutines 1.3.8-1.4.0-rc, fix type inference issues.

* Kotlin 1.4.0.

* Coroutines 1.3.9.
itsandreramon pushed a commit to itsandreramon/Store that referenced this pull request Feb 26, 2025
….INFINITE (MobileNativeFoundation#195)

* Update to Kotlin 1.4.0-rc and Coroutines 1.3.8-1.4.0-rc, fix type inference issues.

* Kotlin 1.4.0.

* Coroutines 1.3.9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants