Avoid using Duration.INFINITE #189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It currently breaks consumers compiling with Kotlin 1.4-M3 (not sure why). Added some TODOs to revert back to using Duration.INFINITE once Store is compiled with Kotlin 1.4 Closes MobileNativeFoundation#188
Contributor
Author
|
This works for me in https://github.com/chrisbanes/tivi/ 🎉 |
eyalgu
approved these changes
Jul 23, 2020
Contributor
|
ty! |
rallat
pushed a commit
that referenced
this pull request
Aug 13, 2021
It currently breaks consumers compiling with Kotlin 1.4-M3 (not sure why). Added some TODOs to revert back to using Duration.INFINITE once Store is compiled with Kotlin 1.4 Closes #188
itsandreramon
pushed a commit
to itsandreramon/Store
that referenced
this pull request
Feb 26, 2025
It currently breaks consumers compiling with Kotlin 1.4-M3 (not sure why). Added some TODOs to revert back to using Duration.INFINITE once Store is compiled with Kotlin 1.4 Closes MobileNativeFoundation#188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It currently breaks consumers compiling with Kotlin 1.4-M3 (not sure why).
Added some TODOs to revert back to using Duration.INFINITE
once Store is compiled with Kotlin 1.4
Closes #188