Emit source of truth errors to subscribers #177 #180
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yigit
requested review from
digitalbuddha and
eyalgu
and removed request for
digitalbuddha
Collaborator
Author
|
oh wait sth is wrong i think i need to rebase w/ master |
Collaborator
Author
|
oh i missed the branch name change (:fist_raised: ), rebased over main now, will push. |
yigit
force-pushed
the
yigit/sot-errors-177
branch
from
14cdeb0 to
da52f4f
Compare
Codecov Report
@@ Coverage Diff @@
## main #180 +/- ##
============================================
- Coverage 86.01% 84.67% -1.34%
- Complexity 230 231 +1
============================================
Files 54 54
Lines 951 992 +41
Branches 149 164 +15
============================================
+ Hits 818 840 +22
- Misses 76 85 +9
- Partials 57 67 +10
Continue to review full report at Codecov.
|
Now source of truth can unblock reader while also letting them know that an error happened while writing. This forces readers to first dispatch the error then whatever data they have. I've also added new public WriteException/ReadException classes to SourceOfTruth so that it is easy to diagnose these problems when it hits to the developer's code
yigit
force-pushed
the
yigit/sot-errors-177
branch
from
da52f4f to
08f7768
Compare
store/src/main/java/com/dropbox/android/external/store4/SourceOfTruth.kt
Outdated
Show resolved
Hide resolved
store/src/main/java/com/dropbox/android/external/store4/impl/RealStore.kt
Outdated
Show resolved
Hide resolved
digitalbuddha
approved these changes
Jun 19, 2020
rallat
pushed a commit
that referenced
this pull request
Aug 13, 2021
* reproduce #177 and fix reader errors * dispatch write errors to receiver Now source of truth can unblock reader while also letting them know that an error happened while writing. This forces readers to first dispatch the error then whatever data they have. I've also added new public WriteException/ReadException classes to SourceOfTruth so that it is easy to diagnose these problems when it hits to the developer's code
itsandreramon
pushed a commit
to itsandreramon/Store
that referenced
this pull request
Feb 26, 2025
…MobileNativeFoundation#180) * reproduce MobileNativeFoundation#177 and fix reader errors * dispatch write errors to receiver Now source of truth can unblock reader while also letting them know that an error happened while writing. This forces readers to first dispatch the error then whatever data they have. I've also added new public WriteException/ReadException classes to SourceOfTruth so that it is easy to diagnose these problems when it hits to the developer's code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where if SourceOfTruth's read or write method fails, we would just crash.
Now SourceOfTruth has two new exception types, WriteException and ReadException where each exception is sent to downstream as a
StoreResponse.Error.Exceptionand stream is kept alive.If a write fails, reader is simply restarted (because it was previously stopped to prepare for the write).
If a read fails, reader is not restarted until another write attempt happens. This is don't to avoid creating an infinite loop of trying to read from disk.