Skip to content

Add Store RxJava3 module #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eyalgu merged 1 commit into from
May 30, 2020
Merged

Add Store RxJava3 module #171

eyalgu merged 1 commit into from
May 30, 2020

Conversation

@mezpahlan
Copy link
Contributor

@mezpahlan mezpahlan commented May 16, 2020

Resolves #131 . This is a lift and shift of the current :store-rx2 module into a new :store-rx3 module with the following changes:

  1. RxJava3 dependency used exclusively throughout :store-rx3 module
  2. Kotlinx Coroutines Rx3 used exclusively throughout :store-rx3 module
  3. Replaced Completable.blockingGet() with Completable.blockingAwait().
  4. Clarified the naming of coroutinesRx2 in the ext.libraries section of dependencies.gradle

eyalgu
eyalgu approved these changes May 30, 2020
View reviewed changes
Copy link
Contributor

@eyalgu eyalgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! sorry for the delay

@eyalgu eyalgu merged commit 10da116 into MobileNativeFoundation:master May 30, 2020
itsandreramon pushed a commit to itsandreramon/Store that referenced this pull request Feb 26, 2025
@mezpahlan
Add Store RxJava3 module (MobileNativeFoundation#171)
5ddbb5a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@eyalgu eyalgu eyalgu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature Request] RxJava 3 bindings

2 participants

@mezpahlan @eyalgu