Skip to content

Conversation

@DYJParker
Copy link
Contributor

…to refer to the externally released version of Store.

Build passes.

@DYJParker DYJParker requested a review from digitalbuddha April 23, 2020 20:02
Copy link
Contributor

@digitalbuddha digitalbuddha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@digitalbuddha digitalbuddha merged commit fc8da86 into MobileNativeFoundation:master Apr 23, 2020
eyalgu added a commit that referenced this pull request Apr 29, 2020
@eyalgu eyalgu linked an issue Apr 29, 2020 that may be closed by this pull request
eyalgu added a commit that referenced this pull request Apr 29, 2020
* Support non exception errors from fetcher

* revert parital changes to store builder to reduce noise

* finish off diff

* Allow to create a FetcherResult.Error without a Throwable. Add tests

* Add missing funcion and more tests

* lint

* unflake RxFlowableStoreTest

* try to rename FakeFetcher to FakeRxFetcher to (maybe) solve missing codcov

* move SourceOfTruth out of impl package

* Rename accidental change of RxStoreBuilder.fromMaybe back to formSingle

* Introduce Fetcher from #139

* fix Rx artifact

* delete legacy presistor factory

* fix api file

* move fetcher to be a typealias

* code review comments + clean up documentation

* code review comments

* Update store/src/main/java/com/dropbox/android/external/store4/Fetcher.kt

Co-Authored-By: Yigit Boyar <[email protected]>

* Revert "Update sample app's build.gradle to refer to the externally released version of Store (#159)"

This reverts commit fc8da86.

* update releasing.md

Co-authored-by: Yigit Boyar <[email protected]>
itsandreramon pushed a commit to itsandreramon/Store that referenced this pull request Feb 26, 2025
itsandreramon pushed a commit to itsandreramon/Store that referenced this pull request Feb 26, 2025
* Support non exception errors from fetcher

* revert parital changes to store builder to reduce noise

* finish off diff

* Allow to create a FetcherResult.Error without a Throwable. Add tests

* Add missing funcion and more tests

* lint

* unflake RxFlowableStoreTest

* try to rename FakeFetcher to FakeRxFetcher to (maybe) solve missing codcov

* move SourceOfTruth out of impl package

* Rename accidental change of RxStoreBuilder.fromMaybe back to formSingle

* Introduce Fetcher from MobileNativeFoundation#139

* fix Rx artifact

* delete legacy presistor factory

* fix api file

* move fetcher to be a typealias

* code review comments + clean up documentation

* code review comments

* Update store/src/main/java/com/dropbox/android/external/store4/Fetcher.kt

Co-Authored-By: Yigit Boyar <[email protected]>

* Revert "Update sample app's build.gradle to refer to the externally released version of Store (MobileNativeFoundation#159)"

This reverts commit fc8da86.

* update releasing.md

Co-authored-by: Yigit Boyar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When should we have the sample app point to released artifacts?

2 participants