Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #557. merged several CryptoLib/OpenSSL fixes #564

Merged
merged 5 commits into from
Apr 20, 2021

Conversation

dkimitsa
Copy link
Contributor

…n file descriptor op fails (like no more failes available) destructor of AppData will try to release not initialized mutex (will cause a crash)
…/secadv/20101116-2.txt) that were causing the crash due multiple release of s->session->tlsext_ecpointformatlist due race in multithreading
…ltithreading

(https://android-review.googlesource.com/c/platform/external/conscrypt/+/68360)

We guard all state with a single lock "stateLock", which
replaces usages of "this" and "handshakeLock". We do not
perform any blocking operations while holding this lock.
In particular, startHandshake is no longer synchronized.
We use a single integer to keep track of handshake state
instead of a pair of booleans.
Also fix a bug in getSession, the previous implementation
wouldn't work in cut-through mode.
@dkimitsa
Copy link
Contributor Author

long read

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants