Add support to NI.getFlags on Darwin #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to NI.getFlags on Darwin
|
@vbousquet thanks ! |
|
I have tested it quite a bit since the PR and published the application (https://apps.apple.com/us/app/familys-game-pack/id1133300130) with Crashlytics that monitors it (thanks for AltPod !). Everything works fine on my side and tests, and I don't have any reports in Crashlytics on that part from the users. I think it should be good to be merged without too much risks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetworkInterface.getFlags always fail on Darwin (see robovm/robovm#1158) since it uses ioctl which is not reliable. This PR proposes to use getifaddr instead (like what has been done for other methods of NetworkInterface by the original authors, see robovm/robovm#1137).
I have only tested this on my setup (iPhone arm64) where it works fine.