ios13_postfix#3: compiler, fix for exception on JVM bridged methods with @Bridge annotation #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to handle overridden covariant return type methods. This fixes compiler exception while compiling `NWTxtRecord` class: java.lang.IllegalArgumentException: @bridge annotated method <org.robovm.apple.network.NWTxtRecord: org.robovm.apple.foundation.NSObject copy()> must be native at org.robovm.compiler.BridgeMethodCompiler.validateBridgeMethod(BridgeMethodCompiler.java:87) at org.robovm.compiler.BridgeMethodCompiler.doCompile(BridgeMethodCompiler.java:233)
|
more details in post |
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Dec 17, 2019
…bridge is able to build now. But it crashes runtime as CLASS INFO structure is corrupted. Root case for this: bridge pointer is not added(as result of MobiVM#422) but MI_BRO_BRIDGE is added to method flags. This flags makes runtime to expect the pointer but it missing and entire class struct is shifted and missread into crash
Tom-Ski
pushed a commit
that referenced
this pull request
Jan 10, 2020
* * jetbrains intellij plugin for gradle version updated * * intellij maven pom reworked into stand-alone. as mvn:version is not able to update parent version number * * added sonatype repo for snapshot dependencies * * eclipse plugin's maven.pom switched into standalone (without) as tyho plugin is not able update parent's version during release * * release script reworked to properly pick up new idea artifact and update it gradle version * * Idea: release script updated to use property to specify the dependencies. otherview version:commit failed to pick up non existing dependencies (for future version) * * as result of #422 covariant return type methods annotated by @bridge is able to build now. But it crashes runtime as CLASS INFO structure is corrupted. Root case for this: bridge pointer is not added(as result of #422) but MI_BRO_BRIDGE is added to method flags. This flags makes runtime to expect the pointer but it missing and entire class struct is shifted and missread into crash
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 9, 2020
…to handle overridden covariant return type methods. This fixes compiler exception while compiling `NWTxtRecord` class: (MobiVM#422) java.lang.IllegalArgumentException: @bridge annotated method <org.robovm.apple.network.NWTxtRecord: org.robovm.apple.foundation.NSObject copy()> must be native at org.robovm.compiler.BridgeMethodCompiler.validateBridgeMethod(BridgeMethodCompiler.java:87) at org.robovm.compiler.BridgeMethodCompiler.doCompile(BridgeMethodCompiler.java:233)
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 9, 2020
* * jetbrains intellij plugin for gradle version updated * * intellij maven pom reworked into stand-alone. as mvn:version is not able to update parent version number * * added sonatype repo for snapshot dependencies * * eclipse plugin's maven.pom switched into standalone (without) as tyho plugin is not able update parent's version during release * * release script reworked to properly pick up new idea artifact and update it gradle version * * Idea: release script updated to use property to specify the dependencies. otherview version:commit failed to pick up non existing dependencies (for future version) * * as result of MobiVM#422 covariant return type methods annotated by @bridge is able to build now. But it crashes runtime as CLASS INFO structure is corrupted. Root case for this: bridge pointer is not added(as result of MobiVM#422) but MI_BRO_BRIDGE is added to method flags. This flags makes runtime to expect the pointer but it missing and entire class struct is shifted and missread into crash
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 9, 2020
…to handle overridden covariant return type methods. This fixes compiler exception while compiling `NWTxtRecord` class: (MobiVM#422) java.lang.IllegalArgumentException: @bridge annotated method <org.robovm.apple.network.NWTxtRecord: org.robovm.apple.foundation.NSObject copy()> must be native at org.robovm.compiler.BridgeMethodCompiler.validateBridgeMethod(BridgeMethodCompiler.java:87) at org.robovm.compiler.BridgeMethodCompiler.doCompile(BridgeMethodCompiler.java:233)
dkimitsa
added a commit
to dkimitsa/robovm
that referenced
this pull request
Apr 9, 2020
* * jetbrains intellij plugin for gradle version updated * * intellij maven pom reworked into stand-alone. as mvn:version is not able to update parent version number * * added sonatype repo for snapshot dependencies * * eclipse plugin's maven.pom switched into standalone (without) as tyho plugin is not able update parent's version during release * * release script reworked to properly pick up new idea artifact and update it gradle version * * Idea: release script updated to use property to specify the dependencies. otherview version:commit failed to pick up non existing dependencies (for future version) * * as result of MobiVM#422 covariant return type methods annotated by @bridge is able to build now. But it crashes runtime as CLASS INFO structure is corrupted. Root case for this: bridge pointer is not added(as result of MobiVM#422) but MI_BRO_BRIDGE is added to method flags. This flags makes runtime to expect the pointer but it missing and entire class struct is shifted and missread into crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds logic to skip bridged synthetic JVM methods added by compiler to handle overridden covariant return type methods. This fixes compiler exception while compiling
NWTxtRecordclass: