Enabling Maven debug options #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dukescript
commented
Jan 29, 2018
| @@ -82,7 +82,7 @@ public void beforeLaunch(Config config, LaunchParameters parameters) { | |||
|
|
|||
| String logDir = argumentValue(arguments, ARG_KEY_LOG_DIR, config.getTmpDir().getAbsolutePath()); | |||
| int jdwpPort = argumentIntValue(arguments, ARG_KEY_JDWP_PORT); | |||
| boolean jdwpClientMode = argumentBoolValue(arguments, ARG_KEY_CLIENT_MODE); | |||
| boolean jdwpClientMode = argumentValue(arguments, ARG_KEY_CLIENT_MODE, false); | |||
There was a problem hiding this comment.
The client mode option shall be optional, I guess.
dukescript
commented
Jan 29, 2018
| </dependencies> | ||
|
|
||
| <build> | ||
| <plugins> | ||
| <plugin> | ||
| <groupId>org.apache.maven.plugins</groupId> | ||
| <artifactId>maven-plugin-plugin</artifactId> | ||
| <version>3.2</version> | ||
| <version>3.5</version> |
There was a problem hiding this comment.
Necessary to let the .class file analyzer to process JDK8 files with lamdas.
dkimitsa
reviewed
Jan 31, 2018
plugins/maven/plugin/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.mobidevelop.robovm</groupId> | ||
| <artifactId>robovm-debugger</artifactId> | ||
| <version>${project.version}</version> |
There was a problem hiding this comment.
please remove version from here and add reference to debugger in <dependencyManagement> of plugins/maven/pom.xml
|
@dkimitsa is this mergeable? |
|
@florianf it looks ok for me |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution to #254 - enabling the
-Drobovm.debugand-Drobovm.debugPortoptions again. The debugger seems to start and listens or connects.