Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add switchElementsAlt() to the default switches #93

Merged

Conversation

BehindTheMath
Copy link
Collaborator

Fixes #83.

@BehindTheMath BehindTheMath force-pushed the bugfix/add-switchElementsAlt branch 2 times, most recently from a2a3c6d to 047f8e9 Compare December 19, 2017 20:51

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Fixes MoOx#83.
@BehindTheMath BehindTheMath force-pushed the bugfix/add-switchElementsAlt branch from 047f8e9 to 0781f82 Compare December 19, 2017 20:56
@BehindTheMath BehindTheMath requested a review from MoOx December 19, 2017 21:37
@BehindTheMath
Copy link
Collaborator Author

@MoOx I can't figure out why testling is erroring. This PR shouldn't affect that.

The affected tests are here.

@MoOx
Copy link
Owner

MoOx commented Dec 20, 2017

@BehindTheMath since you have been added as a collaborator to this repo, you don't need to use your fork anymore and can cut a branch directly from this repo!

@MoOx
Copy link
Owner

MoOx commented Dec 20, 2017

It seems that CI found a regression. Note that testling should be used directly (see note in package.json) if you want to run existing tests

@BehindTheMath
Copy link
Collaborator Author

From the Travis logs, it looks like the regression was caused by #80. However, I don't see anything in that PR either that would cause this error.

Additionally, I ran testling locally in a VM, and it passed with no errors.

So I'm going to take the output of testling with a grain of salt, until it can be switched for an updated testing framework.

@BehindTheMath BehindTheMath merged commit 0916c74 into MoOx:master Dec 20, 2017
@BehindTheMath BehindTheMath deleted the bugfix/add-switchElementsAlt branch December 20, 2017 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants