Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cacheBust option #71

Merged
merged 2 commits into from
Jun 28, 2016
Merged

Add cacheBust option #71

merged 2 commits into from
Jun 28, 2016

Conversation

tremby
Copy link
Contributor

@tremby tremby commented Jun 24, 2016

This addresses #70.

@MoOx MoOx merged commit 7976f06 into MoOx:master Jun 28, 2016
@MoOx
Copy link
Owner

MoOx commented Jun 28, 2016

I was about to cut a release but got this issue locally:

# test xhr request
# - request is made, gets a result, and is cache-busted
not ok 1 Error: TypeError: 'undefined' is not an object (evaluating 'r.responseURL.indexOf') on line 12906

Any idea if that can be cause by what you did here?

@MoOx
Copy link
Owner

MoOx commented Jun 28, 2016

(I think tests are running via safari on my machine, testling is choosing by itself)

@tremby
Copy link
Contributor Author

tremby commented Jun 28, 2016

The tests ran OK for me in Firefox. It's possible there's a bug. I'll look into this when I get time (in the next few days), if you don't find the issue before then.

@tremby
Copy link
Contributor Author

tremby commented Jul 5, 2016

It's working fine in Safari 9.1 but I can reproduce the problem in Safari 8. Looking into it.

@tremby
Copy link
Contributor Author

tremby commented Jul 5, 2016

I've fixed the test for Safari 8 in #73.

@MoOx
Copy link
Owner

MoOx commented Jul 11, 2016

Released in 0.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants