Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch linting to ESLint and Prettier #191

Merged
merged 4 commits into from
Feb 14, 2019
Merged

Switch linting to ESLint and Prettier #191

merged 4 commits into from
Feb 14, 2019

Conversation

BehindTheMath
Copy link
Collaborator

Close #97.

@BehindTheMath
Update package-lock.json
7929523 
package-lock.json was not in sync with package.json, which was
causing Travis to fail.
@BehindTheMath
Copy link
Collaborator Author

I'm not sure why Travis is failing now. .eslintignore excludes node_modules/**.

MoOx
MoOx reviewed Jan 2, 2019
View reviewed changes
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.eslintignore Outdated Show resolved Hide resolved
@BehindTheMath
Copy link
Collaborator Author

@MoOx How about now?

@MoOx
Copy link
Owner

MoOx commented Feb 13, 2019

Looks good!

@BehindTheMath BehindTheMath merged commit 3c1a4b2 into master Feb 14, 2019
@BehindTheMath BehindTheMath deleted the feature/eslint-and-prettier branch February 14, 2019 03:27
@BehindTheMath BehindTheMath mentioned this pull request Mar 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoOx MoOx MoOx approved these changes

@robinnorth robinnorth Awaiting requested review from robinnorth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BehindTheMath @MoOx