New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix evalScripts() #186

Merged

BehindTheMath merged 2 commits into master from fix/eval-script

Nov 25, 2018

Collaborator

BehindTheMath commented Nov 22, 2018

Set the id of the insert <script>.
Check if the <script> still exists before trying to remove it.

Fixes #185.


          Fix evalScripts()

33519f0

* Set the id of the insert <script>.
* Check if the <script> still exists before trying to remove it.

BehindTheMath requested a review from robinnorth

November 22, 2018 02:34


          Fix tests

723b37c

robinnorth approved these changes

View reviewed changes

Collaborator

robinnorth left a comment

This all looks good to me 👍

BehindTheMath merged commit 2c6506a into master

BehindTheMath deleted the fix/eval-script branch

November 25, 2018 20:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment