Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiling instructions for Apple Silicon #606

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

KapJI
Copy link
Contributor

@KapJI KapJI commented Nov 9, 2023

Setting this variable actually breaking build on my Macbook with Apple Silicon.

I get this error:

Detecting compiler hash for triplet arm64-osx...
error: while detecting compiler information:
The log file content at "/Users/sayfutdinov/Project/github/EternalTerminal/external/vcpkg/buildtrees/detect_compiler/stdout-arm64-osx.log" is:
-- Configuring arm64-osx-rel
CMake Error at scripts/cmake/vcpkg_execute_required_process.cmake:112 (message):
    Command failed: /opt/homebrew/Cellar/cmake/3.27.7/bin/cmake /Users/sayfutdinov/Project/github/EternalTerminal/external/vcpkg/scripts/detect_compiler -G Ninja -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/Users/sayfutdinov/Project/github/EternalTerminal/external/vcpkg/packages/detect_compiler_arm64-osx -DCMAKE_SYSTEM_NAME=Darwin -DBUILD_SHARED_LIBS=OFF -DVCPKG_CHAINLOAD_TOOLCHAIN_FILE=/Users/sayfutdinov/Project/github/EternalTerminal/external/vcpkg/scripts/toolchains/osx.cmake -DVCPKG_TARGET_TRIPLET=arm64-osx -DVCPKG_SET_CHARSET_FLAG=ON -DVCPKG_PLATFORM_TOOLSET=external -DCMAKE_EXPORT_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_PACKAGE_REGISTRY=ON -DCMAKE_FIND_PACKAGE_NO_SYSTEM_PACKAGE_REGISTRY=ON -DCMAKE_INSTALL_SYSTEM_RUNTIME_LIBS_SKIP=TRUE -DCMAKE_VERBOSE_MAKEFILE=ON -DVCPKG_APPLOCAL_DEPS=OFF -DCMAKE_TOOLCHAIN_FILE=/Users/sayfutdinov/Project/github/EternalTerminal/external/vcpkg/scripts/buildsystems/vcpkg.cmake -DCMAKE_ERROR_ON_ABSOLUTE_INSTALL_DESTINATION=ON -DVCPKG_CXX_FLAGS= -DVCPKG_CXX_FLAGS_RELEASE= -DVCPKG_CXX_FLAGS_DEBUG= -DVCPKG_C_FLAGS= -DVCPKG_C_FLAGS_RELEASE= -DVCPKG_C_FLAGS_DEBUG= -DVCPKG_CRT_LINKAGE=dynamic -DVCPKG_LINKER_FLAGS= -DVCPKG_LINKER_FLAGS_RELEASE= -DVCPKG_LINKER_FLAGS_DEBUG= -DVCPKG_TARGET_ARCHITECTURE=arm64 -DCMAKE_INSTALL_LIBDIR:STRING=lib -DCMAKE_INSTALL_BINDIR:STRING=bin -D_VCPKG_ROOT_DIR=/Users/sayfutdinov/Project/github/EternalTerminal/external/vcpkg -DZ_VCPKG_ROOT_DIR=/Users/sayfutdinov/Project/github/EternalTerminal/external/vcpkg -D_VCPKG_INSTALLED_DIR=/Users/sayfutdinov/Project/github/EternalTerminal/build/vcpkg_installed -DVCPKG_MANIFEST_INSTALL=OFF -DCMAKE_OSX_ARCHITECTURES=arm64
    Working Directory: /Users/sayfutdinov/Project/github/EternalTerminal/external/vcpkg/buildtrees/detect_compiler/arm64-osx-rel
    Error code: 1
    See logs for more information:
      /Users/sayfutdinov/Project/github/EternalTerminal/external/vcpkg/buildtrees/detect_compiler/config-arm64-osx-rel-CMakeCache.txt.log
      /Users/sayfutdinov/Project/github/EternalTerminal/external/vcpkg/buildtrees/detect_compiler/config-arm64-osx-rel-out.log
      /Users/sayfutdinov/Project/github/EternalTerminal/external/vcpkg/buildtrees/detect_compiler/config-arm64-osx-rel-err.log

Call Stack (most recent call first):
  scripts/cmake/vcpkg_configure_cmake.cmake:340 (vcpkg_execute_required_process)
  scripts/detect_compiler/portfile.cmake:18 (vcpkg_configure_cmake)
  scripts/ports.cmake:147 (include)



error: vcpkg was unable to detect the active compiler's information. See above for the CMake failure output.

Without this variable it builds fine.

@KapJI KapJI changed the title Add compiling instructions for Apple Silicon Update compiling instructions for Apple Silicon Nov 9, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2f8dfdd) 73.47% compared to head (b7abd6b) 73.25%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #606      +/-   ##
==========================================
- Coverage   73.47%   73.25%   -0.22%     
==========================================
  Files          50       50              
  Lines        3042     3051       +9     
==========================================
  Hits         2235     2235              
- Misses        807      816       +9     

see 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MisterTea
Copy link
Owner

Thanks!

@MisterTea MisterTea merged commit bfe08fc into MisterTea:master Nov 10, 2023
18 of 21 checks passed
@KapJI KapJI deleted the patch-1 branch November 10, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants