Update spritz.js #70
Open
Update spritz.js #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a redundant call to see if the length of word was divisible buy two, with both branches doing the same thing.
|
Yo dawg, I see you like optimizations, so I optimized your optimization. |
tomByrer
added a commit
to tomByrer/OpenSpritz
that referenced
this pull request
Mar 13, 2014
Miserlou#70 patched wrong branch Not sure why this is? ```js var start = ''; var end = ''; start = decodeEntities(word.slice(0, word.length/2)); end = decodeEntities(word.slice(word.length/2, word.length)); ```
|
This PR should be closed in preference to my PR (used right branch). But you spotted an perf op well @ciderpunx ! thanks :) |
|
@ciderpunx totally random question, but did you ever post on the Nothing Nice To Say / n00dplz forums? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a redundant call to see if the length of word was divisible by two, with both branches doing the same thing.