Merged
Conversation
In case of FULL join having a scalar source producing no outputs, do not replace the join with the other source if it cannot be determined to have at least one row. If the other source turns out to be empty, we would get empty result after such replacement. This is incorrect. The single input row from the scalar source should be preserved on output.
This is an enhancement of the section about IntelliJ IDEA's inspections. Proper handling of language injection is unfortunately not automatic, and there is no objective truth to how to do it. But since we're working with SQL statements a lot, I find it useful.
This reverts commit 231853b.
This is a legacy method that is only used with table layouts.
Use a row level delete instead of dropping partitions when running a delete that exactly matches entire partitions.
This commit fixes bug #7298, in which SQL UPDATE failed with an exception when applied to a transactional table originally created using CREATE TABLE AS SELECT... CREATE TABLE AS SELECT... results in table files that don't have the ACID transaction, rowId and bucket columns even though the table was declared as transactional. DELETE of original files worked because OrcFileWriterFactory adds a different rowId column adaptation for original files than for normal transactional delta files. However, UPDATE did not have that special column adaptation. This commit adds that rowId adaptation that works for UPDATE on original files. This commit adds a several tests, two that verify that UPDATE with original files now work correctly for both partitioned and unpartitioned tables, and another to show that DELETE already worked correctly with original files. This commit also adds a method to verify that the data file paths for original files conform to the formats genenerated by Hive and Trino, and uses that method in all the tests of original files.
Replace List<Integer> and streams with IntList. Simple benchmarks show roughly 2.5x-5x performance gain.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.