41 using internal hooks #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… execution path. This allows moving all the logic related to handling the request / response to the hooks and makes the router quite more flexible
…lly so any hook can add their own options/settings. And create new core package to solve circular dependencies problems. Refactor went out of hand and there are quite a bit of changes but in return the router is fully extensible and configurable now. Still a WIP, pending to fix some test issues
…rser/stringify and fix 404 handler.
…ormance still quite worst 😢
|
Some work was done to implement this, it required quite a bit changes, creating new pacakges and in general adding complexity. There was quite a bit of degradation as well! Branch here: https://github.com/MionKit/mion/tree/41-using-internal-hooks
Do to this we are not proceeding with the merging as it has too many disadvantages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a methods to prepend and append hooks.
these hooks are intended for internal router functioning. the goal is that the router only contains logic about creating and dispatching routes, and any other logic related to the request/response parsing serialized etx is handled using hooks.
This is so the router or any other plugging can add hooks without modifying existing routes
Prepend and append hooks should be called called before any register routes so there is no need to remade all the routes.
resolves #41