Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 15, 2025

Addresses raw pointer lifetime cast failure fixed in metrics-rs/metrics#564.

Changes

  • riven/Cargo.toml: Bump metrics from 0.24.0 to 0.24.2
  • Cargo.lock: Update locked version from 0.24.1 to 0.24.2
Original prompt

This section details on the original issue you should resolve

<issue_title>bug: raw pointer lifetime cast failing in metrics, fixed by metrics-rs/metrics#564</issue_title>
<issue_description>metrics will need to be updated to 0.24.2 per metrics-rs/metrics#564 (comment)</issue_description>

<agent_instructions>Please update the cargo.lock file to pin metrics to 0.24.2 (from 0.24.1, I believe), either via the cargo command or manually editing.</agent_instructions>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Update metrics dependency to version 0.24.2 Update metrics to 0.24.2 to fix raw pointer lifetime cast bug Dec 15, 2025
Copilot AI requested a review from MingweiSamuel December 15, 2025 18:27
@MingweiSamuel MingweiSamuel marked this pull request as ready for review December 15, 2025 18:40
Copilot AI review requested due to automatic review settings December 15, 2025 18:40
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the metrics dependency from 0.24.0 to 0.24.2 to address a raw pointer lifetime cast bug that was fixed upstream in metrics-rs/metrics#564.

Key Changes:

  • Updated metrics dependency version requirement in riven/Cargo.toml from 0.24.0 to 0.24.2

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MingweiSamuel MingweiSamuel merged commit dbf9029 into v/2.x.x Dec 15, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: raw pointer lifetime cast failing in metrics, fixed by https://github.com/metrics-rs/metrics/pull/564

2 participants