-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to enchanting and minecarts #28
Conversation
@jamespeilunli this diff is really hard to read because I broke "section 4" into two, moving the existing sections 5-7 to now be 6-8. I deleted some images that weren't being used. I moved images out of a specific section folder because I foresee more section renaming in the future, so just having all images in the root images folder makes that less laborious. For review, just look at the end result of sections 4 and 5 and review for correctness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe everything is correct, but I added a few suggestions on some things to add.
Great recommendations, @jamespeilunli! I'll work on adding this as soon as I can |
I've addressed all your feedback. Give me another reivew. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
resolves #26