Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates to enchanting and minecarts #28

Merged
merged 2 commits into from
Apr 17, 2022
Merged

Conversation

dealingwith
Copy link
Member

@dealingwith dealingwith commented Apr 10, 2022

resolves #26

@dealingwith dealingwith self-assigned this Apr 10, 2022
@dealingwith
Copy link
Member Author

@jamespeilunli this diff is really hard to read because I broke "section 4" into two, moving the existing sections 5-7 to now be 6-8.

I deleted some images that weren't being used.

I moved images out of a specific section folder because I foresee more section renaming in the future, so just having all images in the root images folder makes that less laborious.

For review, just look at the end result of sections 4 and 5 and review for correctness.

@dealingwith
Copy link
Member Author

For review, just look at the end result of sections 4 and 5 and review for correctness.

To do this, you can use the "rich diff" viewer available in the header of a markdown file in the "Files changed" tab:
Screen Shot 2022-04-10 at 5 28 20 PM
Screen Shot 2022-04-10 at 5 28 25 PM

Copy link
Contributor

@jamespeilunli jamespeilunli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe everything is correct, but I added a few suggestions on some things to add.

level_2/section_4.md Outdated Show resolved Hide resolved
level_2/section_4.md Show resolved Hide resolved
level_2/section_4.md Show resolved Hide resolved
@dealingwith
Copy link
Member Author

Great recommendations, @jamespeilunli! I'll work on adding this as soon as I can

@dealingwith
Copy link
Member Author

I've addressed all your feedback. Give me another reivew. 😄

Copy link
Contributor

@jamespeilunli jamespeilunli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jamespeilunli jamespeilunli merged commit 1ab4fd8 into main Apr 17, 2022
@dealingwith dealingwith deleted the 26-enchanting-update branch April 17, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure enchanting is up to date
2 participants