[1.21.3] Pass player argument when firing OnDatapackSyncEvent
#10170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 12, 2024
autoforge
bot
added
Triage
Jonathing
approved these changes
Nov 12, 2024
autoforge
bot
added
Assigned
|
Shit happens |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago I submitted a pull request to add back the patch to fire the
OnDatapackSyncEventevent inPlayerList#placeNewPlayer, #10076. This was supposed to be a straight copy from the patch in 1.20.4 (PlayerList.java.patch), however it seems I made a mistake and somehow managed to putnullfor the player argument rather than passing the player object.This PR simply passes the player object to the event rather than
null.