Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#98 feedbackonbuttons #99

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Conversation

TheRealAgentK
Copy link
Contributor

Description 📝

Fixes #98

Adds some Snackbar notification on actions in the sample app.

Type of change

Delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Updates

👉 Added Material UI lib
👉 Added Snackbars on button actions, resource strings in strings.xml

Author to check 👓

  • Project and all contained modules build
  • Tested on appropriate devices/emulators and SDK versions
    - [] Reviewed by another developer
    N/A
  • Appropriate documentation written (code comments, internal docs)

Reviewer to check ✔️

  • Change has been tested on a device/emulator
  • Code is written to standards
    - [ ] Appropriate tests have been written (code comments, internal docs)
    N/A

Copy link
Collaborator

@sumitramanga sumitramanga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments to address but otherwise mostly looks good! Thank you for implementing this change ⭐

@sumitramanga
Copy link
Collaborator

Hi @TheRealAgentK ! Just wanted to check in to see if you'll have time to work on this? :)

@TheRealAgentK TheRealAgentK merged commit e8e9264 into develop Aug 30, 2024
@TheRealAgentK TheRealAgentK deleted the feature/#98-feedbackonbuttons branch August 30, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants