Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover backgrounds #438

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Cover backgrounds #438

merged 1 commit into from
Jun 13, 2024

Conversation

nicolube
Copy link
Contributor

The background images in the audio / voicechat Tab did not cover, they did repeat.

@Mindgamesnl
Copy link
Owner

Hey there, thanks for the PR!
I'll get it merged for now, but mostly as a temporary solution. this would ideally be something that the server owner can configure, as there might be servers who use smaller tiling patterns.

@Mindgamesnl Mindgamesnl merged commit 6e4ac65 into Mindgamesnl:master Jun 13, 2024
1 check passed
@nicolube
Copy link
Contributor Author

nicolube commented Jun 13, 2024 •
edited
Loading

Hey there, thanks for the PR! I'll get it merged for now, but mostly as a temporary solution. this would ideally be something that the server owner can configure, as there might be servers who use smaller tiling patterns.

Well the login / settings page was handled like this, but not the other 2 wich makes it kind of inconsistent.

@nicolube nicolube deleted the bugfix/client_background_cover branch June 13, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicolube @Mindgamesnl