Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework commands #384

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

Mindgamesnl
Copy link
Owner

I started working on the preload/unload commands when I realized how convoluted some of the current command handling is.

This PR contains the following core changes:

  • Player selectors are now part of the Platform
  • the User interface can now inherit the actual type of its parent (Player, CommandSender, CommandSource, etc.)
  • the SpigotPlayerSelector, BungeePlayerSelector, and VelocityPlayerSelector now all implement one interface (SelectorTranslator<>`), which is platform agnostic, though some specific platform features can still be accessed through its T param.
  • Some commands are essentially re-implemented per platform and can now carry a single implementation, this affects
    • /oa play
    • /oa stop
    • /audio (and aliasses)
    • .. and new commands implemented from here on out

@Mindgamesnl Mindgamesnl merged commit 6409e76 into development Jan 25, 2024
2 of 3 checks passed
@Mindgamesnl Mindgamesnl deleted the feature/command-and-selector-rework branch January 25, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant