Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Swift 5️⃣.5️⃣ #250

Merged
merged 1 commit into from
Feb 9, 2022
Merged

Migrate to Swift 5️⃣.5️⃣ #250

merged 1 commit into from
Feb 9, 2022

Conversation

p4checo
Copy link
Member

@p4checo p4checo commented Feb 1, 2022

Checklist

Motivation and Context

GH Actions' macOS 11 images have Xcode 13 available which means that Swift 5.5 is available to use in CI.

macOS-11 image Xcode Reference

Description

  • Update ci.yml:

    • DEVELOPER_DIR to point to Xcode 13.2.1.
    • IOS_SDK to point to iphonesimulator15.2.
    • PLATFORM_TARGET to point to x86_64-apple-ios15.2-simulator.
  • Update Package.swift's // swift-tools-version to 5.5.

  • Update podspec's swift_version to 5.5.

  • Set Swift 5 version at the project level.

  • Update carthage.sh workaround for Carthage builds fail at xcrun lipo on Xcode 12 beta (3,4,5...) Carthage/Carthage#3019 to handle Xcode 13.

  • Update README.md.

@p4checo p4checo requested a review from a team February 1, 2022 09:54
@p4checo p4checo self-assigned this Feb 1, 2022
@codecov
Copy link

codecov bot commented Feb 1, 2022

Codecov Report

Merging #250 (07711cd) into master (58d5838) will decrease coverage by 2.95%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #250      +/-   ##
==========================================
- Coverage   94.97%   92.01%   -2.96%     
==========================================
  Files          99       99              
  Lines        3281     3281              
==========================================
- Hits         3116     3019      -97     
- Misses        165      262      +97     
Impacted Files Coverage Δ
Sources/Extensions/Foundation/DispatchQueue.swift 50.00% <0.00%> (-50.00%) ⬇️
...ces/Network/Pinning/SecCertificate+PublicKey.swift 64.28% <0.00%> (-21.43%) ⬇️
...a/NSPersistentStoreCoordinator+CoreDataStack.swift 60.00% <0.00%> (-20.00%) ⬇️
Sources/View/ReusableView.swift 51.89% <0.00%> (-17.73%) ⬇️
Sources/Network/HTTPResourceEndpoint.swift 70.00% <0.00%> (-10.00%) ⬇️
...urces/Persistence/DiskMemoryPersistenceStack.swift 80.15% <0.00%> (-7.94%) ⬇️
...es/StackOrchestrator/StackOrchestrator+Store.swift 92.56% <0.00%> (-6.09%) ⬇️
Sources/Network/Pinning/ServerTrustEvaluator.swift 86.74% <0.00%> (-6.03%) ⬇️
...sistence/CoreData/NestedContextCoreDataStack.swift 90.38% <0.00%> (-5.77%) ⬇️
...ng/ItemFormatters/Log+StringLogItemFormatter.swift 94.44% <0.00%> (-5.56%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58d5838...07711cd. Read the comment docs.

GH Actions' macOS 11 images have Xcode 13 available which means that
Swift 5.5 is available to use in CI.

https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11-Readme.md#xcode

## Changes

- Update `ci.yml`:
  + `DEVELOPER_DIR` to point to Xcode 13.2.1.
  + `IOS_SDK` to point to `iphonesimulator15.2`.
  + `PLATFORM_TARGET` to point to `x86_64-apple-ios15.2-simulator`.

- Update Package.swift's `// swift-tools-version` to 5.5.

- Update podspec's `swift_version` to 5.5.

- Set Swift 5 version at the project level.

- Update `carthage.sh` workaround for Carthage/Carthage#3019 to handle
Xcode 13.

- Update `README.md`.
Copy link

@mindera-ios-interview mindera-ios-interview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@p4checo p4checo merged commit 5dc9b0f into master Feb 9, 2022
@p4checo p4checo deleted the migrate-to-swift-5.5 branch February 9, 2022 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants