Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Swift 5️⃣.3️⃣ #231

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Migrate to Swift 5️⃣.3️⃣ #231

merged 1 commit into from
Apr 13, 2021

Conversation

p4checo
Copy link
Member

@p4checo p4checo commented Apr 12, 2021

Checklist

Motivation and Context

Migrate to Xcode 12 and Swift 5.3.

Description

  • Migrate travis.yml image to xcode12.2.

  • Update SPM Platform target to x86_64-apple-ios14.0-simulator.

  • Update podspec's swift_version to 5.3.

  • Update README.md.

  • Clean up SwiftLint warnings.

  • Remove --verbose argument from pod lib lint to avoid making Travis angry with the log length and failing the build with the message: "The job exceeded the maximum log length, and has been terminated." 😅

@p4checo p4checo requested a review from a team April 12, 2021 15:43
@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #231 (c29b3bf) into master (c7d6dd2) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #231      +/-   ##
==========================================
- Coverage   95.02%   94.99%   -0.03%     
==========================================
  Files          97       97              
  Lines        3295     3296       +1     
==========================================
  Hits         3131     3131              
- Misses        164      165       +1     
Impacted Files Coverage Δ
...es/StackOrchestrator/StackOrchestrator+Store.swift 98.64% <ø> (ø)
Sources/StackOrchestrator/StackOrchestrator.swift 100.00% <ø> (ø)
...ces/StackOrchestrator/StackOrchestratorStore.swift 91.89% <ø> (ø)
Sources/Network/Network+ErrorDecoding.swift 100.00% <100.00%> (ø)
...rces/Persistence/CoreData/CoreDataStack+CRUD.swift 98.42% <100.00%> (ø)
Sources/Network/Network+URLSessionResource.swift 95.34% <0.00%> (-2.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d6dd2...c29b3bf. Read the comment docs.

Migrate to Xcode 12 and Swift 5.3.

## Changes

- Migrate travis.yml image to `xcode12.2`.

- Update SPM Platform target to `x86_64-apple-ios14.0-simulator`.

- Update podspec's `swift_version` to 5.3.

- Update `README.md`.

- Clean up SwiftLint warnings.

- Remove `--verbose` argument from `pod lib lint` to avoid making
Travis angry with the log length and failing the build with the message:
"The job exceeded the maximum log length, and has been terminated." 😅

- Attempt to fix flaky test in `URLSessionNetworkStackTestCase` 🤞
@p4checo p4checo merged commit 1221eca into master Apr 13, 2021
@p4checo p4checo deleted the migrate-to-swift-5.3 branch April 13, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants