Dev/alfmob-81 add to bag

[mrfreitas]

Add product to bag using the button add to bag on product detail
This is implemented using only an im memory cache, basically it is matching what IOS have.
Some TODO were added to change it latter to use DB or api to proper save the items.

Also the list for the bag scree was implemented, again it was implemented to match IOS and have feature parity.

[rsousamindera]

I know this was moved from place, but if possible can we improve the mapping to be less reliant on the properties of the price?

as far as I know when mapping the domain model Price on the data layer mapper, there is a PriceInfo as well as a MoneyInfo that we can map and improve the information that is being passed along. specially the PriceInfo that contains a ProductPriceDisplayType which can then be mapped also to a type that can then be used here and have specific mappings per type, which will be less error prone once we have more price types and conditions

in theory we would only need the domain price to look something like this:

data class Price(
    val displayType: PriceDisplayType,
    val amount: Money,
    val was: Money?
)

[rsousamindera]

we might be able to not pass this state information back to the view model, since it should already be accessible there.

I'm aware there might be a few different cases where the product has only one variant or only a color or one size, but all these cases we can either infer the selected variant (by lack of options) or the user needs to select them beforehand (updating the state in the view model), so all the information should be available before we attempt to add an item to the bag

[mrfreitas]

Sorry, i don't understand the suggestion, are you suggestion to pass only the id as a parameter on the click event?

[rsousamindera]

I believe the product structure we have in place it by having a Product ID that represents all the Variants of said product. The Variant then represents a Color and a Size making it a unique item. was expecting the AddToBagUseCase to receive a Variant ID and not a Product ID, which I believe is what is being passed as an argument or did I miss something?

[mrfreitas]

I don't know what are the diferences between a variant and a product, also variant don't have id, it has sku, but i'm confused, maybe a call to explain better these diferences will be necessary!

[rsousamindera]

usually the hierarchy is (from more generic to unique):

• Product: has an identifier (usually ID) and has generic information about a certain item. we can't add this to a back for instance, maybe to a Wishlist sometimes
• Colour: has an identifier (also usually an ID) and there can be a multitude of colours in a Product or it can be a single colour for instance
• Size: has an identifier (can be ID or SKU or something like that) and once you have the Size it is a unique item that can then be added to the bag for instance

so what I was trying to say is that in order for us to add something to the bag we need a unique identifier which represents a specific product with a specific colour on a certain size

from what I see in the API schemas all of this can be represented by a Variant which will have all the combinations possible for sizes and colours alike and also contain the identifier we need to add to the bag ( we can't use the product, colour or size to perform the query, but we can use it to get the right Variant.

in summary, don't think we can use the addToBagUseCase(item.id) which seems to use the Product ID and something unique like a Variant ID/SKU

let me know if it clear enough or is something else I can help with

[QaziMashhood]

@rsousamindera
Yes makes complete sense. So, what i ll be doing is that, when user adds something to bag, then i will be saving 2 things

• Product Id
• Variant SKU

Using this information, whenever user opens the bag, we will be able to show the correct product with the correct variant.
Is there something that i am missing or this makes sense to you as well?

[rsousamindera]

can you explain a little more the idea behind getting the product from the repository and then add it in case the response is successful? couldn't we just add the item right away?

[mrfreitas]

I don't understand your question, are you asking why im getting the product from the repository?

[rsousamindera]

sorry maybe I wasn't clear enough: was asking to clarify the reason why we are getting a product (productRepository.getProduct(productId = productId)) and then add it (bagRepository.addToBag(it))

I understand this is a temporary approach so we can display items in the Bag, so maybe in the future we only need to provide the arguments for a query and only change the Use Case (which is pretty good). just wanted to be sure this was the case

maybe it would help having a small comment explaining the reasoning since it might not be clear right away without some context