Fixes to migration script #15456
Merged
Fixes to migration script #15456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emberian
reviewed
Apr 3, 2024
scripts/archive/migration/README.md
Outdated
|
|
||
| ``` | ||
| ./scripts/archive/migration/berkeley_migration.sh final -g ../../umt_testing/o1labs-umt-pre-fork-run-1-ledger.json -s postgres://postgres:postgres@localhost:5432/umt_testing_final -t postgres://postgres:postgres@localhost:5432/migrated -b mina_network_block_data -bs 50 -n o1labs-umt-pre-fork-run-1 -r migration-checkpoint-2381.json -fc ../../umt_testing/fork-umt-02-29-2024.json -f 3NLnD1Yp4MS9LtMXikD1YyySZNVgCXA82b5eQVpmYZ5kyTo4Xsr7 | ||
| ./scripts/archive/migration/berkeley_migration.sh final -g ../../umt_testing/o1labs-umt-pre-fork-run-1-ledger.json -s postgres://postgres:postgres@localhost:5432/umt_testing_final -t postgres://postgres:postgres@localhost:5432/migrated -b mina_network_block_data -bs 50 -n o1labs-umt-pre-fork-run-1 -r migration-checkpoint-2381.json -fc ../../umt_testing/fork-umt-02-29-2024.json |
There was a problem hiding this comment.
Suggested change
| ./scripts/archive/migration/berkeley_migration.sh final -g ../../umt_testing/o1labs-umt-pre-fork-run-1-ledger.json -s postgres://postgres:postgres@localhost:5432/umt_testing_final -t postgres://postgres:postgres@localhost:5432/migrated -b mina_network_block_data -bs 50 -n o1labs-umt-pre-fork-run-1 -r migration-checkpoint-2381.json -fc ../../umt_testing/fork-umt-02-29-2024.json | |
| ./scripts/archive/migration/mina-berkeley-migration-script final -g ../../umt_testing/o1labs-umt-pre-fork-run-1-ledger.json -s postgres://postgres:postgres@localhost:5432/umt_testing_final -t postgres://postgres:postgres@localhost:5432/migrated -b mina_network_block_data -bs 50 -n o1labs-umt-pre-fork-run-1 -r migration-checkpoint-2381.json -fc ../../umt_testing/fork-umt-02-29-2024.json |
There was a problem hiding this comment.
This is part of another PR, I thought :D
There was a problem hiding this comment.
Don't mind merging your commit from there to here to avoid more micro PRs
emberian
approved these changes
Apr 3, 2024
|
!ci-build-me |
dkijania
approved these changes
Apr 3, 2024
|
Testing the script didn't work. Going to investigate tomorrow |
|
It turned out the |
|
!approved-for-mainnet |
ghost-not-in-the-shell
approved these changes
Apr 4, 2024
Problem: parameter is clearly redundant Solution: take the value from the fork config
Problem: migration verifier tool and migration script incorrectly named genesis config of the fork network as the fork config which introduced certain confusion. Solution: rename all such occurences of fork config to fork genesis config.
georgeee
force-pushed
the
georgeee/fixes-to-migration-script
branch
from
e0537a8 to
b228412
Compare
|
!ci-build-me |
|
!approved-for-mainnet |
7 tasks
dkijania
approved these changes
Apr 4, 2024
|
#15467 for ensuring the docs are updated and tested as well after this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain your changes:
--fork-state-hashfromfinalstepgrep '"level":"Error"'instead ofgrep Errorfor checking errors in logs--fork-configand--fork-config-fileparameters in migration script/verifier to--fork-genesis-configExplain how you tested your changes:
Checklist: