Skip to content

Conversation

@mrmr1993
Copy link
Contributor

@mrmr1993 mrmr1993 commented Apr 3, 2024

This PR is part of the fix for o1-labs/o1js#1374, against the o1js-main branch, via o1-labs/proof-systems#2054. The added test exercises this behaviour, and only passes after the fix to proof-systems is applied.

@mrmr1993 mrmr1993 requested a review from a team as a code owner April 3, 2024 15:37
@mrmr1993
Copy link
Contributor Author

mrmr1993 commented Apr 3, 2024

!ci-build-me

Copy link
Contributor

@mitschabaude mitschabaude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful!

@mrmr1993 mrmr1993 requested a review from a team as a code owner April 4, 2024 10:35
@mitschabaude
Copy link
Contributor

!ci-build-me

@mitschabaude
Copy link
Contributor

A unit test which seems to compare a hard-coded circuit digest is failing

@mitschabaude
Copy link
Contributor

!ci-build-me

@mitschabaude mitschabaude merged commit c56bde5 into o1js-main Apr 5, 2024
@mitschabaude mitschabaude deleted the fix/lookup-gate-range-check branch April 5, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants