docs(rfc): RFC-0027 ACP Subagent Zed Compatibility by Million-mo · Pull Request #95 · Million-mo/wh

Million-mo · 2026-08-22T01:47:51Z

Summary

Add RFC-0027: ACP Subagent Zed Compatibility — a 12-round Oracle+Metis reviewed RFC for AgentPool ACP subagent compatibility with Zed editor.

Key Design Decisions

display_mode=zed as 4th enum value (alongside legacy/inline/tool_box) — explicit config, no auto-detection
_meta.subagent_session_info extension on SpawnSessionStart's ToolCallStart — JSON Object, not string
Phase 1-3 implementation plan: _meta filling → child session creation → message index tracking
Phase 1 explicit drop: non-StreamCompleteEvent SubAgentEvents discarded in zed mode; Phase 2 routes to child session

GAP Analysis (5 gaps addressed)

GAP	Priority	Description
GAP 1	P0	`_meta` never populated on ToolCallStart/ToolCallProgress
GAP 2	P1	No child ACP session for subagent content
GAP 3	P1	SpawnSessionStart not used for ACP signaling
GAP 4	P2	No message_start_index/message_end_index
GAP 5	P2	tool_name not in _meta

Review History

12 rounds of Oracle + Metis review
Final: Oracle APPROVED (P2/P3 only), Metis APPROVED (P2 only)
Key simplification: SubagentRoutingMode enum + clientInfo auto-detection → single display_mode=zed

Test Plan

Phase 1 includes 8+ test items covering: _meta presence/absence guards, SubagentSessionInfo model, ACP snapshot tests, StreamCompleteEvent field_meta, explicit drop behavior.

备份迁移自 SRC-PR#26 · 作者 @Leoyzen · 创建于 2026-04-24T13:53:54Z · head=feature/yuchen.liu/rfc-0027-zed-subagent base=develop/agentic
源状态: closed · merge_commit_sha=b4d9c9277df887e1aee7804ecf5023d8ff9c2601

12-round Oracle+Metis reviewed RFC for AgentPool ACP subagent compatibility with Zed editor. Key design: display_mode=zed as 4th enum value, _meta.subagent_session_info extension, Phase 1-3 implementation plan.

Million-mo · 2026-08-22T02:44:48Z

评论 by @Million-mo 于 2026-07-17T09:58:23Z（备份迁移）

状态分析

此 PR 的内容已存在于主分支中，且 RFC-0027 描述的功能已完全实现。

具体情况

PR 仅包含 1 个文件 docs/rfcs/draft/RFC-0027-acp-subagent-zed-compatibility.md（1217 行）

该文件已存在于主分支，内容一致，状态为 DRAFT

RFC-0027 的实现已通过 PR [PR #376] docs(rfc): RFC-0060 Agent Mode Declaration for OpenCode At-Mention Visibility #65 大重构合入主分支：

subagent_display_mode: Literal["legacy", "zed", "qwen"] 覆盖 6 个文件

SubagentSessionInfo 模型（event_converter.py:122）

_build_subagent_field_meta() helper（event_converter.py:235）

子会话创建与路由（session_manager.py）

Guardrail 测试（tests/acp/test_meta_guardrails.py）

原 RFC-0027 实现 PR Bug: TestModel produces empty text content in OpenCode multi-turn (E2 red-flag) #42 和 POST /init hangs in CI — fire-and-forget agent run blocks on TestModel subprocess #45 已关闭（功能已被主分支覆盖）

结论

文档和实现均已完成，关闭此 PR。

Million-mo · 2026-08-22T02:44:49Z

评论 by @Million-mo 于 2026-07-30T06:53:44Z（备份迁移）

Synthesized Review: chore: test opencode review trigger

Verdict: ✅ Acceptable as a throwaway test PR. Do not merge to main.

Code Review

No code concerns. No source files touched. Type safety, testing, telemetry, and architecture consistency are all N/A.

The single-line change (README.md +1) is well-scoped for its purpose.

Docs Review

Stale artifact duplication (HIGH). Line 209 (# test) is a pre-existing artifact from a prior test. This PR adds line 210 (# test review) alongside it — two meaningless H1 headings at the end of README.md.

Heading hierarchy broken (MEDIUM). Both use H1 (#), the same level as the document title. The rest of the file uses ##/###.

No impact on AGENTS.md context loading table, subsystem AGENTS.md files, docs/explanation/ links, or document placement rules.

Recommendation

Lines 209–210 must be reverted before any real merge to main. Since this PR is explicitly a trigger test, consider closing it without merging and using throwaway branches for future trigger tests to avoid accumulating artifacts on main.

Million-mo · 2026-08-22T02:44:51Z

评论 by @Million-mo 于 2026-07-30T06:57:23Z（备份迁移）

PR Review: chore: test opencode review trigger

Overall: ✅ Acceptable as a trigger-test PR — do not merge to main without cleanup.

Code Review (review-code)

Area Verdict Notes

Type safety ✅ N/A No source files changed

Testing ✅ N/A No test files changed

Telemetry ✅ N/A No instrumented code paths affected

Architecture ✅ No architecture concerns

Finding: Zero Python files touched. No code concerns. ✓

Docs Review (review-docs)

Area Verdict Notes

AGENTS.md context table ✅ Unaffected

Subsystem AGENTS.md ✅ Unaffected

docs/explanation/ coverage / link integrity ✅ Unaffected

Heading hierarchy ❌ Broken README.md:209-210 — # test and # test review add two orphan H1s. The document's only legitimate H1 is # AgentPool (line 1); all sections use ##/###.

README cleanliness ❌ Test artifacts pollute user-facing documentation; second artifact compounds the pre-existing one

Key Findings

Trivial test change — aligns with commit message. All three trigger modes (pull_request, issue_comment, workflow_dispatch) verified.

Heading hierarchy violation — Two H1 headings at the end of README.md break Markdown structure. Both # test (pre-existing from a prior test) and # test review (this PR) are structural errors.

README.md is not a test fixture — Using the project's primary landing page for trigger tests leaves garbage in a user-facing file.

Recommendations

Close without merging once trigger verification is complete.

Clean up both README.md:209-210 (# test and # test review) before any production merge to main.

For future trigger tests, use a dedicated test branch that is never merged to main, or a temp fixture file.

Million-mo · 2026-08-22T02:44:53Z

评论 by @Million-mo 于 2026-07-30T07:02:39Z（备份迁移）

PR Review: chore: test opencode review trigger

Verdict: ✅ Acceptable as a trigger test — close without merging to main.

Code Review (review-code)

Area Verdict Notes

Type safety ✅ N/A No .py files touched

Testing ✅ N/A No test infrastructure affected

Telemetry ✅ N/A No instrumented code paths touched

Architecture ✅ N/A No modules, protocols, or handlers changed

No code risk. Trivial README-only change. No OpenSpec needed per AGENTS.md section 101–107 (not a significant change).

Docs Review (review-docs)

Area Verdict Notes

AGENTS.md context table ✅ Unaffected README.md is correctly absent (it is the GitHub landing page, not contributor docs)

Subsystem AGENTS.md files ✅ Unaffected All 6 subsystem files untouched

docs/explanation/ / link integrity ✅ Unaffected No docs/ files changed; no links added/removed

README heading hierarchy ❌ Broken Lines 209–210 add two H1s (# test, # test review) after the documents natural end (line 208). Only # AgentPool (line 1) is the legitimate H1

Doc quality / artifact pollution ❌ Compounds pre-existing # test artifact (line 209) with another orphaned heading

Key Findings

Trivial CI trigger test — The change fulfills its stated purpose of verifying pull_request, issue_comment, and workflow_dispatch trigger modes. All three modes have been exercised.

Heading hierarchy violated — README.md:209-210: # test (pre-existing) and # test review (this PR) are orphaned H1s with no body content, violating the one-H1-per-document Markdown convention.

Compounded artifact problem — The pre-existing # test on main was never cleaned up; this PR adds a second alongside it.

README.md is not a test fixture — Using the projects primary landing page for trigger tests leaves permanent garbage in a user-facing file.

Recommendations

Close without merging once trigger verification is complete — the goal has been achieved and all three trigger modes work.

Clean up both README.md:209 (# test) and README.md:210 (# test review) in a follow-up PR before any production merge to main.

For future trigger tests, use a dedicated branch that is never merged to main, or write to a temporary fixture file instead of README.md.

Million-mo · 2026-08-22T02:44:55Z

评论 by @Million-mo 于 2026-07-30T07:03:42Z（备份迁移）

PR Review: chore: test opencode review trigger

Overall: ✅ Acceptable as a trigger test — close without merging to main. The three trigger modes (pull_request, issue_comment, workflow_dispatch) have been exercised.

Code Review (review-code) — ✅ PASS

Area Verdict Notes

Type safety ✅ N/A No .py files touched

Testing ✅ N/A No test infrastructure changed

Telemetry ✅ N/A No instrumented codepaths affected

Architecture ✅ N/A Trivial README-only change; no OpenSpec needed

Findings: None. The diff is minimal, scoped, and the commit message matches the intent.

Docs Review (review-docs) — 🔴 2 findings

Area Verdict Notes

AGENTS.md context table ✅ Unaffected README.md is correctly absent (user-facing landing page, not contributor docs)

Subsystem AGENTS.md files ✅ Unaffected All 6 subsystem files untouched

docs/explanation/ / link integrity ✅ Unaffected No docs/ files touched; no links added/removed

README heading hierarchy 🔴 Broken Lines 209–210 add two orphaned H1s (# test, # test review) to a document whose only legitimate H1 is # AgentPool (line 1). The rest of the doc uses ##/###. H1 after H2 is a Markdown convention violation.

README cleanliness 🔴 Artifact pollution README.md is the public project homepage. Stray # test headings are debug remnants with zero informational value, and compound the pre-existing # test artifact on line 209.

Key Findings

Trivial CI trigger test — The change is well-scoped for its stated purpose.

Heading hierarchy violated — README.md:209-210 are orphaned H1s appended after the document's natural conclusion under ## Documentation.

Compounded artifact problem — The pre-existing # test (line 209, from a prior trigger test) was never cleaned up; this PR adds # test review alongside it.

Pre-existing doc integrity issue (not caused by this PR): AGENTS.md:79 references docs/explanation/team-mode.md, but that file does not exist on disk. Worth a follow-up fix.

Recommendations

Close without merging once trigger verification is complete — the goal has been achieved.

Remove both README.md:209 (# test) and README.md:210 (# test review) before any production merge to main.

For future trigger tests, use a dedicated branch never merged to main, or write to a temp fixture file instead of README.md.

Follow-up: Fix the stale docs/explanation/team-mode.md link in AGENTS.md:79.

Million-mo · 2026-08-22T02:44:56Z

评论 by @Million-mo 于 2026-07-30T07:05:40Z（备份迁移）

Synthesized Review: chore: test opencode review trigger

Code Review — ✅ No concerns

Area Verdict Notes

Type safety ✅ PASS No .py files changed

Testing ✅ PASS No test infrastructure affected

Telemetry ✅ PASS No instrumented code paths touched

Architecture ✅ PASS Trivial README-only change; OpenSpec bypass acceptable for CI test

Docs Review — 🔴 2 findings

Area Verdict Notes

AGENTS.md context table ✅ Unaffected

Subsystem AGENTS.md ✅ Unaffected

docs/explanation/ / links ✅ Unaffected

Heading hierarchy 🔴 Broken Lines 209–210 add two orphaned H1s (# test pre-existing, # test review this PR) to a document whose only legitimate H1 is # AgentPool (line 1). The document consistently uses ##/### for sections.

README cleanliness 🔴 Artifact pollution Test headings have zero user value and compound pre-existing # test artifact

Pre-existing: team-mode.md link ⚠️ AGENTS.md:78 references docs/explanation/team-mode.md which does not exist on disk (not introduced by this PR)

Summary

Trivial CI trigger test — commit message matches the change. Three trigger modes (pull_request, issue_comment, workflow_dispatch) have been exercised.

Heading hierarchy violated — both # test and # test review are orphaned H1s at end of file after the document's natural conclusion.

Pre-existing broken link — AGENTS.md:78 → docs/explanation/team-mode.md is a 404 on disk (follow-up fix needed).

Recommendations

Close without merging once trigger verification is complete.

Remove both README.md:209 (# test) and README.md:210 (# test review) before any production merge to main.

Fix stale link in AGENTS.md:78 (team-mode.md does not exist).

For future trigger tests, use a dedicated branch never merged to main, or write to a temporary fixture file instead of README.md.

Million-mo · 2026-08-22T02:44:58Z

评论 by @Million-mo 于 2026-07-30T07:06:32Z（备份迁移）

Synthesized PR Review: chore: test opencode review trigger

Verdict: ✅ Acceptable as a trigger test — revert before merging to main.

Code Review — ✅ PASS

Area Verdict Notes

Type safety ✅ N/A No .py files touched

Testing ✅ N/A No test infrastructure changed

Telemetry ✅ N/A No instrumented code paths affected

Architecture ✅ N/A Trivial README-only change; OpenSpec bypass is appropriate for this scope

No code concerns. The commit message accurately describes intent — this is a CI trigger test.

Docs Review — 🔴 3 findings

Area Verdict Notes

AGENTS.md context table ✅ Unaffected README.md not in the context table (correct — it is a user-facing landing page)

Subsystem AGENTS.md files ✅ Unaffected All 6 subsystem */AGENTS.md files untouched

docs/explanation/ links ✅ Unaffected No docs/ files changed

README heading hierarchy 🔴 HIGH README.md:209-210: # test (pre-existing) and # test review (this PR) are orphaned H1s appended after the document's natural conclusion. Only # AgentPool (line 1) is the legitimate H1 — all sections use ##/###.

README cleanliness 🔴 HIGH User-facing landing page contaminated with debug headings that have zero informational value. Compounds pre-existing # test artifact.

Dead link (pre-existing) 🔴 MEDIUM AGENTS.md:78 references docs/explanation/team-mode.md — this file does not exist on disk.

Key Findings

Trivial CI trigger test — The change fulfills its stated purpose: exercising pull_request, issue_comment, and workflow_dispatch trigger modes.

Heading hierarchy violated — README.md:209-210: two extra H1s break Markdown convention (one H1 per document).

Compounded artifact problem — The pre-existing # test (line 209, from a prior test on main) was never cleaned up; this PR adds # test review alongside it.

Dead link in AGENTS.md (pre-existing) — docs/explanation/team-mode.md referenced at AGENTS.md:78 is missing from disk.

Recommendations

Close without merging once trigger verification is complete — all three modes have been exercised.

Remove both README.md:209 (# test) and README.md:210 (# test review) before any production merge to main.

For future trigger tests, use a dedicated branch never merged to main, or write to a temporary fixture file instead of README.md.

Follow-up: Fix the stale team-mode.md link at AGENTS.md:78.

docs(rfc): add RFC-0027 ACP subagent Zed compatibility

c6b45b6

12-round Oracle+Metis reviewed RFC for AgentPool ACP subagent compatibility with Zed editor. Key design: display_mode=zed as 4th enum value, _meta.subagent_session_info extension, Phase 1-3 implementation plan.

Million-mo closed this Aug 22, 2026

This was referenced Aug 22, 2026

refactor: Thin-wrapper refactor — pdai Capability-first architecture (#74) #156

Closed

[PR #101] feat(scripts): Phase 8 — automated rename script agentpool → agentwolf #164

Closed

This was referenced Aug 22, 2026

[Refactor] Thin-wrapper refactor: pdai Capability-first architecture + rename to agentwolf #139

Closed

[Phase 2] Run Stream Unification — Deprecate BaseAgent.run_stream() #141

Closed

Conversation

Million-mo commented Aug 22, 2026

Summary

Key Design Decisions

GAP Analysis (5 gaps addressed)

Review History

Test Plan

Phase 1 includes 8+ test items covering: _meta presence/absence guards, SubagentSessionInfo model, ACP snapshot tests, StreamCompleteEvent field_meta, explicit drop behavior.

Uh oh!

Million-mo commented Aug 22, 2026

状态分析

具体情况

结论

Uh oh!

Million-mo commented Aug 22, 2026

Synthesized Review: chore: test opencode review trigger

Code Review

Docs Review

Recommendation

Uh oh!

Million-mo commented Aug 22, 2026

PR Review: chore: test opencode review trigger

Code Review (review-code)

Docs Review (review-docs)

Key Findings

Recommendations

Uh oh!

Million-mo commented Aug 22, 2026

PR Review: chore: test opencode review trigger

Code Review (review-code)

Docs Review (review-docs)

Key Findings

Recommendations

Uh oh!

Million-mo commented Aug 22, 2026

PR Review: chore: test opencode review trigger

Code Review (review-code) — ✅ PASS

Docs Review (review-docs) — 🔴 2 findings

Key Findings

Recommendations

Uh oh!

Million-mo commented Aug 22, 2026

Synthesized Review: chore: test opencode review trigger

Code Review — ✅ No concerns

Docs Review — 🔴 2 findings

Summary

Recommendations

Uh oh!

Million-mo commented Aug 22, 2026

Synthesized PR Review: chore: test opencode review trigger

Code Review — ✅ PASS

Docs Review — 🔴 3 findings

Key Findings

Recommendations

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Synthesized Review: `chore: test opencode review trigger`

PR Review: `chore: test opencode review trigger`

PR Review: `chore: test opencode review trigger`

PR Review: `chore: test opencode review trigger`

Synthesized Review: `chore: test opencode review trigger`

Synthesized PR Review: `chore: test opencode review trigger`