Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting overhaul #278

Merged
merged 5 commits into from
Jan 6, 2024
Merged

Formatting overhaul #278

merged 5 commits into from
Jan 6, 2024

Conversation

MilesCranmer
Copy link
Owner

@MilesCranmer MilesCranmer commented Jan 6, 2024

  • Adds pre-commit to run formatting automatically. Also applies formatting rules to markdown and yaml.
  • Replace all unnecessary instances of import with using to increase idiomaticness

Copy link
Contributor

github-actions bot commented Jan 6, 2024

Benchmark Results

master d49e85b... t[master]/t[d49e85b...]
search/multithreading 23 ± 1.1 s 21.8 ± 0.37 s 1.06
search/serial 30.1 ± 0.77 s 29.7 ± 0.76 s 1.01
utils/best_of_sample 0.792 ± 0.25 μs 1.08 ± 0.48 μs 0.732
utils/check_constraints_x10 12.2 ± 3.1 μs 12.2 ± 3.1 μs 1.01
utils/compute_complexity_x10/Float64 2.25 ± 0.12 μs 2.25 ± 0.12 μs 1
utils/compute_complexity_x10/Int64 2.26 ± 0.12 μs 2.27 ± 0.12 μs 0.996
utils/compute_complexity_x10/nothing 1.49 ± 0.1 μs 1.49 ± 0.11 μs 0.999
utils/optimize_constants_x10 28.4 ± 6.2 ms 29.8 ± 6.7 ms 0.954
time_to_load 1.32 ± 0.0078 s 1.34 ± 0.0046 s 0.988

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@MilesCranmer MilesCranmer changed the title Add pre-commit configuration Formatting overhaul Jan 6, 2024
@MilesCranmer MilesCranmer merged commit 40ce0b4 into master Jan 6, 2024
27 checks passed
@MilesCranmer MilesCranmer deleted the pre-commit branch January 6, 2024 18:47
MilesCranmer added a commit that referenced this pull request Feb 19, 2024
[Diff since v0.23.1](v0.23.1...v0.23.2)

**Merged pull requests:**
- Formatting overhaul (#278) (@MilesCranmer)
- Avoid julia-formatter on pre-commit.ci (#279) (@MilesCranmer)
- Make it easier to select expression from Pareto front for evaluation (#289) (@MilesCranmer)

**Closed issues:**
- Garbage collection too passive on worker processes (#237)
- How can I set the maximum number of nests? (#285)
MilesCranmer added a commit that referenced this pull request Feb 19, 2024
[Diff since v0.23.1](v0.23.1...v0.23.2)

**Merged pull requests:**
- Formatting overhaul (#278) (@MilesCranmer)
- Avoid julia-formatter on pre-commit.ci (#279) (@MilesCranmer)
- Make it easier to select expression from Pareto front for evaluation (#289) (@MilesCranmer)

**Closed issues:**
- Garbage collection too passive on worker processes (#237)
- How can I set the maximum number of nests? (#285)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant