Refactor update_backend.yml workflow #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MilesCranmer
reviewed
Mar 8, 2024
MilesCranmer
reviewed
Mar 8, 2024
|
The key changes here are that the version numbers need to be modified in pyproject.toml and in pysr/juliapkg.json. Previously the workflow was trying to change things in setup.py, which is overwritten (and is in gitignore, so never gets picked up by the pull request step). |
MilesCranmer
changed the title
MilesCranmer
approved these changes
Mar 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@MilesCranmer This PR includes my fixes to this workflow. It should, when run, detect a new backend version, bump the python patch number, and open a PR.
Note that you may need to run modify some repository settings to allow additional action permissions.