Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Python and Julia version in PySR env #365

Closed
wants to merge 5 commits into from

Conversation

MilesCranmer
Copy link
Owner

Rather than @pysr-0.14.2 as the Julia environment, this would make it @pysr-0.14.2-py-3.11-jl-1.9. Thus the user would need to re-install for each combination of Python and Julia they wish to use PySR with. This is to prevent some of the issues noted in #257

cc @mkitti @ngam I wonder if this would pose an issue for conda at all? If I install a different julia version in conda, it would also trigger a new PySR install, right?

@mkitti
Copy link
Contributor

mkitti commented Jul 2, 2023

It is not clear to me that this will work because I'm not sure if PyCall.jl has localized the Python setting to the environment.

What we need is for PyCall.jl is to implement
https://github.com/JuliaPackaging/Preferences.jl

@MilesCranmer
Copy link
Owner Author

Here is the PR: JuliaPy/PyCall.jl#945

Since it’s 2 years old with no recent updates maybe the solution in the meantime is to just delete the PyCall deps whenever someone installs PySR?

@MilesCranmer
Copy link
Owner Author

Actually it probably makes sense to include this regardless for the Julia tag, because the Manifest file might be incompatible (say some Julia package differs for older Julia versions).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants