Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix connectTimeout and receiveTimeout #32

Merged
merged 3 commits into from
Feb 13, 2023
Merged

Fix connectTimeout and receiveTimeout #32

merged 3 commits into from
Feb 13, 2023

Conversation

Carapacik
Copy link
Contributor

No description provided.

@Milad-Akarie
Copy link
Owner

@Carapacik Hey, what does that do?

@Carapacik
Copy link
Contributor Author

Converting object to an encodable object failed: Instance of 'Duration'

@Carapacik
Copy link
Contributor Author

IT fix this and add recommended lints

@Carapacik
Copy link
Contributor Author

Because for dio 5 connectTimeout and receiveTimeout now Duration

@Milad-Akarie
Copy link
Owner

@Carapacik can you check the review tap so I can merge this?

@Carapacik
Copy link
Contributor Author

Yes

@Milad-Akarie
Copy link
Owner

Why change this
value = '"${value.toString().replaceAll(RegExp(r'(\r|\n)+'), " ")}"';
to this
value = '"${value.toString().replaceAll(RegExp(r'([\r\n])+'), " ")}"';

@Carapacik
Copy link
Contributor Author

image
[\r\n] same as \r|\n

@Carapacik
Copy link
Contributor Author

Analyzer error

@Milad-Akarie
Copy link
Owner

I see, alright then.

@Milad-Akarie Milad-Akarie merged commit 21f5127 into Milad-Akarie:master Feb 13, 2023
@Milad-Akarie
Copy link
Owner

published to pub.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants