Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make assertEqualUpToEpsilon show the correct line number #88

Open
Mikolaj opened this issue Mar 6, 2023 · 0 comments
Open

Make assertEqualUpToEpsilon show the correct line number #88

Mikolaj opened this issue Mar 6, 2023 · 0 comments
Labels
help wanted Extra attention is needed

Comments

@Mikolaj
Copy link
Owner

Mikolaj commented Mar 6, 2023

Right now, most of the time, it shows the line it's defined at instead of the one it's called at, where the mistake is made.

HasCallStack is already added wherever possible, so we need to catch and re-throw exceptions or find a way to add HasCallStack to the typeclass (apparently forbidden).
@Mikolaj Mikolaj added the help wanted Extra attention is needed label Mar 6, 2023
Mikolaj added a commit that referenced this issue Mar 6, 2023
@Mikolaj
Add HasCallStack to assertEqualUpToEpsilon, etc., see #88
618148d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Mikolaj