Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use window.devicePixelRatio #91

Closed
mainstreetmark opened this issue Dec 15, 2016 · 2 comments
Closed

Use window.devicePixelRatio #91

mainstreetmark opened this issue Dec 15, 2016 · 2 comments
Assignees
@Mikhus
Labels
bug
Milestone
2.1.1

Comments

@mainstreetmark
Copy link

I seem to be doing a lot of:

...
borderOuterWidth: 3 * window.devicePixelRatio,
borderMiddleWidth: 5 * window.devicePixelRatio,
borderInnerWidth: 3 * window.devicePixelRatio,
...

When I don't do that, I get different appearance between my retina Macbook Pro and my old mini. Should widths be specified in "pixels" and canvas-gauges automatically apply the pixel ratio internally?
@Mikhus
Copy link
Owner

Mikhus commented Dec 16, 2016

It ought to be like that, so it is simply a bug, thank you for contribution.

@Mikhus Mikhus self-assigned this Dec 16, 2016
@Mikhus Mikhus added the bug label Dec 16, 2016
@Mikhus Mikhus added this to the 2.1.1 milestone Dec 16, 2016
Mikhus added a commit that referenced this issue Dec 25, 2016
@Mikhus
Fixed issue #91 - problem with plate borders draw on a device with hi…
008b8d0 
…gh pixel ratio
@Mikhus
Copy link
Owner

Mikhus commented Dec 25, 2016

Fixed in branch v2.1.1

@Mikhus Mikhus closed this as completed Dec 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mikhus Mikhus

Labels
bug
Projects
None yet
Milestone
2.1.1
Development

No branches or pull requests
2 participants
@Mikhus @mainstreetmark