Skip to content

[JitDiff X64] [hez2010] JIT: Update type when return temp is freshly created #962

@MihuBot

Description

@MihuBot

Job completed in 15 minutes 29 seconds (remote runner delay: 1 minute 25 seconds).
dotnet/runtime#111948

Diffs

Diffs
Found 199 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 43640320
Total bytes of diff: 43639846
Total bytes of delta: -474 (-0.00 % of base)
Total relative delta: -0.32
    diff is an improvement.
    relative diff is an improvement.


Top file regressions (bytes):
         370 : System.IO.IsolatedStorage.dasm (1.65 % of base)
         129 : System.ComponentModel.TypeConverter.dasm (0.04 % of base)

Top file improvements (bytes):
        -254 : System.ComponentModel.Annotations.dasm (-0.48 % of base)
        -227 : System.Composition.Convention.dasm (-0.18 % of base)
        -196 : Microsoft.CSharp.dasm (-0.06 % of base)
        -170 : System.Composition.TypedParts.dasm (-0.35 % of base)
         -51 : System.Private.Xml.dasm (-0.00 % of base)
         -21 : System.Private.CoreLib.dasm (-0.00 % of base)
         -18 : System.Formats.Tar.dasm (-0.01 % of base)
         -18 : System.Resources.Extensions.dasm (-0.04 % of base)
         -18 : Microsoft.Extensions.Configuration.FileExtensions.dasm (-0.39 % of base)

11 total files with Code Size differences (9 improved, 2 regressed), 252 unchanged.

Top method regressions (bytes):
          97 (23.43 % of base) : System.ComponentModel.TypeConverter.dasm - System.Drawing.ColorConverter+<>c:<.cctor>b__9_0():System.ComponentModel.TypeConverter+StandardValuesCollection:this (FullOpts)
          52 (14.81 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int,int,int,System.IO.IsolatedStorage.IsolatedStorageFile):this (FullOpts)
          52 (14.73 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int,int,int):this (FullOpts)
          52 (14.21 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int,int,System.IO.IsolatedStorage.IsolatedStorageFile):this (FullOpts)
          52 (14.25 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int,int):this (FullOpts)
          52 (14.09 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int,System.IO.IsolatedStorage.IsolatedStorageFile):this (FullOpts)
          52 (14.02 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int):this (FullOpts)
          49 (30.06 % of base) : System.Private.CoreLib.dasm - System.IO.FileStream:.ctor(Microsoft.Win32.SafeHandles.SafeFileHandle,int):this (FullOpts)
          29 (7.21 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFile:OpenFile(System.String,int,int):System.IO.IsolatedStorage.IsolatedStorageFileStream:this (FullOpts)
          29 (7.04 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFile:OpenFile(System.String,int):System.IO.IsolatedStorage.IsolatedStorageFileStream:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[double]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[int]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[long]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[short]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (0.47 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[System.__Canon]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[System.Nullable`1[int]]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[System.Numerics.Vector`1[float]]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[ubyte]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)

Top method improvements (bytes):
        -254 (-68.65 % of base) : System.ComponentModel.Annotations.dasm - System.ComponentModel.DataAnnotations.CompareAttribute:GetDisplayNameForProperty(System.Reflection.PropertyInfo):System.String:this (FullOpts)
        -227 (-56.05 % of base) : System.Composition.Convention.dasm - System.Composition.Convention.PartConventionBuilder:MemberHasExportMetadata(System.Reflection.MemberInfo):ubyte (FullOpts)
        -196 (-30.02 % of base) : Microsoft.CSharp.dasm - Microsoft.CSharp.RuntimeBinder.Semantics.TypeManager:InternalsVisibleTo(System.Reflection.Assembly,System.Reflection.Assembly):ubyte (FullOpts)
        -170 (-9.00 % of base) : System.Composition.TypedParts.dasm - System.Composition.CompositionContextExtensions:SatisfyImportsInternal(System.Composition.CompositionContext,System.Object,System.Composition.Convention.AttributedModelProvider) (FullOpts)
         -51 (-3.52 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.Xslt.XPathPatternBuilder:BuildPredicates(System.Xml.Xsl.Qil.QilNode,System.Collections.Generic.List`1[System.Xml.Xsl.Qil.QilNode]):System.Xml.Xsl.Qil.QilNode:this (FullOpts)
         -19 (-3.16 % of base) : System.Private.CoreLib.dasm - System.IO.File:WriteAllLinesAsync(System.String,System.Collections.Generic.IEnumerable`1[System.String],System.Text.Encoding,ubyte,System.Threading.CancellationToken):System.Threading.Tasks.Task (FullOpts)
         -18 (-6.57 % of base) : Microsoft.Extensions.Configuration.FileExtensions.dasm - Microsoft.Extensions.Configuration.FileConfigurationProvider:<Load>g__OpenRead|6_0(Microsoft.Extensions.FileProviders.IFileInfo):System.IO.Stream (FullOpts)
         -18 (-0.60 % of base) : System.Formats.Tar.dasm - System.Formats.Tar.TarWriter:ConstructEntryForWriting(System.String,System.String,int):System.Formats.Tar.TarEntry:this (FullOpts)
         -18 (-5.90 % of base) : System.Private.CoreLib.dasm - System.IO.File:AsyncStreamReader(System.String,System.Text.Encoding):System.IO.StreamReader (FullOpts)
         -18 (-4.04 % of base) : System.Resources.Extensions.dasm - System.Resources.Extensions.DeserializingResourceReader:.ctor(System.String):this (FullOpts)
         -18 (-4.04 % of base) : System.Private.CoreLib.dasm - System.Resources.ResourceReader:.ctor(System.String):this (FullOpts)
         -15 (-2.92 % of base) : System.Private.CoreLib.dasm - System.IO.File:ReadLinesAsync(System.String,System.Threading.CancellationToken):System.Collections.Generic.IAsyncEnumerable`1[System.String] (FullOpts)

Top method regressions (percentages):
          49 (30.06 % of base) : System.Private.CoreLib.dasm - System.IO.FileStream:.ctor(Microsoft.Win32.SafeHandles.SafeFileHandle,int):this (FullOpts)
          97 (23.43 % of base) : System.ComponentModel.TypeConverter.dasm - System.Drawing.ColorConverter+<>c:<.cctor>b__9_0():System.ComponentModel.TypeConverter+StandardValuesCollection:this (FullOpts)
          52 (14.81 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int,int,int,System.IO.IsolatedStorage.IsolatedStorageFile):this (FullOpts)
          52 (14.73 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int,int,int):this (FullOpts)
          52 (14.25 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int,int):this (FullOpts)
          52 (14.21 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int,int,System.IO.IsolatedStorage.IsolatedStorageFile):this (FullOpts)
          52 (14.09 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int,System.IO.IsolatedStorage.IsolatedStorageFile):this (FullOpts)
          52 (14.02 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFileStream:.ctor(System.String,int):this (FullOpts)
          29 (7.21 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFile:OpenFile(System.String,int,int):System.IO.IsolatedStorage.IsolatedStorageFileStream:this (FullOpts)
          29 (7.04 % of base) : System.IO.IsolatedStorage.dasm - System.IO.IsolatedStorage.IsolatedStorageFile:OpenFile(System.String,int):System.IO.IsolatedStorage.IsolatedStorageFileStream:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[double]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[int]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[long]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[short]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[System.Nullable`1[int]]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[System.Numerics.Vector`1[float]]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (1.18 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[ubyte]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)
           4 (0.47 % of base) : System.ComponentModel.TypeConverter.dasm - MS.Internal.Xml.Linq.ComponentModel.XTypeDescriptor`1[System.__Canon]:GetProperties(System.Attribute[]):System.ComponentModel.PropertyDescriptorCollection:this (FullOpts)

Top method improvements (percentages):
        -254 (-68.65 % of base) : System.ComponentModel.Annotations.dasm - System.ComponentModel.DataAnnotations.CompareAttribute:GetDisplayNameForProperty(System.Reflection.PropertyInfo):System.String:this (FullOpts)
        -227 (-56.05 % of base) : System.Composition.Convention.dasm - System.Composition.Convention.PartConventionBuilder:MemberHasExportMetadata(System.Reflection.MemberInfo):ubyte (FullOpts)
        -196 (-30.02 % of base) : Microsoft.CSharp.dasm - Microsoft.CSharp.RuntimeBinder.Semantics.TypeManager:InternalsVisibleTo(System.Reflection.Assembly,System.Reflection.Assembly):ubyte (FullOpts)
        -170 (-9.00 % of base) : System.Composition.TypedParts.dasm - System.Composition.CompositionContextExtensions:SatisfyImportsInternal(System.Composition.CompositionContext,System.Object,System.Composition.Convention.AttributedModelProvider) (FullOpts)
         -18 (-6.57 % of base) : Microsoft.Extensions.Configuration.FileExtensions.dasm - Microsoft.Extensions.Configuration.FileConfigurationProvider:<Load>g__OpenRead|6_0(Microsoft.Extensions.FileProviders.IFileInfo):System.IO.Stream (FullOpts)
         -18 (-5.90 % of base) : System.Private.CoreLib.dasm - System.IO.File:AsyncStreamReader(System.String,System.Text.Encoding):System.IO.StreamReader (FullOpts)
         -18 (-4.04 % of base) : System.Resources.Extensions.dasm - System.Resources.Extensions.DeserializingResourceReader:.ctor(System.String):this (FullOpts)
         -18 (-4.04 % of base) : System.Private.CoreLib.dasm - System.Resources.ResourceReader:.ctor(System.String):this (FullOpts)
         -51 (-3.52 % of base) : System.Private.Xml.dasm - System.Xml.Xsl.Xslt.XPathPatternBuilder:BuildPredicates(System.Xml.Xsl.Qil.QilNode,System.Collections.Generic.List`1[System.Xml.Xsl.Qil.QilNode]):System.Xml.Xsl.Qil.QilNode:this (FullOpts)
         -19 (-3.16 % of base) : System.Private.CoreLib.dasm - System.IO.File:WriteAllLinesAsync(System.String,System.Collections.Generic.IEnumerable`1[System.String],System.Text.Encoding,ubyte,System.Threading.CancellationToken):System.Threading.Tasks.Task (FullOpts)
         -15 (-2.92 % of base) : System.Private.CoreLib.dasm - System.IO.File:ReadLinesAsync(System.String,System.Threading.CancellationToken):System.Collections.Generic.IAsyncEnumerable`1[System.String] (FullOpts)
         -18 (-0.60 % of base) : System.Formats.Tar.dasm - System.Formats.Tar.TarWriter:ConstructEntryForWriting(System.String,System.String,int):System.Formats.Tar.TarEntry:this (FullOpts)

30 total methods with Code Size differences (12 improved, 18 regressed), 247281 unchanged.

--------------------------------------------------------------------------------

Artifacts:

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions