-
Notifications
You must be signed in to change notification settings - Fork 0
Description
Triage for dotnet/aspire#10338.
Repo filter: area-dashboard issues.
MihuBot version: 4431de.
Ping MihaZupan for any issues.
This is a test triage report generated by AI, aimed at helping the triage team quickly identify past issues/PRs that may be related.
Take any conclusions with a large grain of salt.
dotnet/aspire#10338: Support uninstrumented peer visualization for parameters, connection strings, and GitHub models resources by davidfowl
[Tool] Searching for uninstrumented peer visualization, parameters connection strings github models, ResourceOutgoingPeerResolver, KnownProperties connectionString Value, trace dashboard uninstrumented peers (IncludeOpen=True, IncludeClosed=True, IncludeIssues=True, IncludePullRequests=True, Repository=dotnet/aspire)
[Tool] Found 50 issues, 108 comments, 50 returned results (9046 ms)
Here are the most relevant related issues and discussions for triaging issue #10338 ("Support uninstrumented peer visualization for parameters, connection strings, and GitHub models resources"):
1. PR #8883 (April 2025) - Treat uninstrumented outgoing peers as instrumented resources in dashboard UI
- Summary: This PR introduced the mechanism for visualizing uninstrumented outgoing peers (such as databases, caches, and infrastructure without built-in tracing) in the Aspire dashboard's traces page. It included changes to how telemetry is loaded and how peers are resolved and displayed in the UI. The PR did not specifically address parameters, connection strings, or GitHub models, but laid the groundwork for the feature requested in #10338.
- Conclusion: The mechanism exists for some resource types, but not yet for parameters, connection strings, or GitHub models.
2. PR #10340 (July 2025) - [WIP] Support uninstrumented peer visualization for parameters, connection strings, and GitHub models resources
- Summary: This is a work-in-progress PR directly addressing issue #10338. The PR description restates the issue and intent to update
ResourceOutgoingPeerResolverto handle known properties likeconnectionStringandValuefor the specified resource types. - Conclusion: Work is underway to implement the requested feature, but the PR is not yet merged.
3. Issue #10335 (July 2025) - Parameters and connection strings should be visible in the dashboard
- Summary: This issue, also opened by davidfowl, requests that parameters and connection strings be made visible in the dashboard, as they were previously hidden. The rationale is that these resources are relevant for configuration and should be visible for better insight.
- Conclusion: Visibility of these resources is being improved, which is a prerequisite for better trace visualization.
4. PR #10336 (July 2025) - Make parameters and connection strings visible in dashboard
- Summary: This PR implements the changes requested in #10335, making parameters and connection strings visible in the dashboard by removing the
IsHidden = truesetting. - Conclusion: This change supports the broader goal of making these resources first-class citizens in the dashboard, which aligns with the goals of #10338.
5. PR #10170 (July 2025) - Add GitHub Models integration and PR #10313 (July 2025) - Add GitHub Models integration (#10170) (release/9.4 backport)
- Summary: These PRs add GitHub Models as a resource type in Aspire, including health checks and parameter handling. There is discussion about the status and health check behavior, but not about trace visualization for uninstrumented peers.
- Conclusion: GitHub Models are now a supported resource type, but uninstrumented peer visualization for them is not yet implemented.
6. PR #9965 (June–July 2025) - Add ExternalServiceResource for modeling external services with service discovery support
- Summary: Introduces a new resource type for modeling external services, with support for parameterized URLs and dashboard integration. This is related to the general theme of modeling and visualizing external dependencies, but does not specifically address parameters, connection strings, or GitHub models.
- Conclusion: Shows ongoing work to improve modeling and visualization of external resources, which is related to the goals of #10338.
7. PR #7826 (Feb–Mar 2025) - Enhance resource management for connection strings
- Summary: Improves management of connection strings and parameters, introducing interfaces and classes to better handle these resources. This is foundational for making parameters and connection strings more visible and manageable.
- Conclusion: Lays groundwork for treating parameters and connection strings as first-class resources.
8. PR #9030 (April 2025) - Only display trace menu option for uninstrumented peer resources
- Summary: UI improvement to only show the trace option for uninstrumented peer resources, indicating ongoing refinement of the dashboard's handling of such resources.
- Conclusion: Related to the UI/UX for uninstrumented peers, but not specifically about parameters, connection strings, or GitHub models.
9. Issue #7649 (Feb–July 2025) - GitHub Models integration
- Summary: Tracks the addition of GitHub Models as a resource type. The discussion is about integration and configuration, not trace visualization.
- Conclusion: Confirms GitHub Models are a new resource type, but does not address uninstrumented peer visualization.
10. PR #1040 (Nov 2023) - Tracing UI displays resource name for outgoing resources
- Summary: Improves the tracing UI to display resource names for outgoing resources, using address-to-resource mapping. This is the technical foundation for the uninstrumented peer visualization feature.
- Conclusion: The mechanism exists for mapping outgoing addresses to resource names, but needs to be extended to more resource types as requested in #10338.
Summary
- The feature for visualizing uninstrumented peers in traces was introduced in Aspire 9.3, but currently does not cover parameters, connection strings, or GitHub models.
- There is an open WIP PR (#10340) that aims to implement the requested feature for these resource types.
- Recent work has made parameters and connection strings visible in the dashboard (#10336), which is a necessary step for full trace integration.
- GitHub Models are now a supported resource type, but uninstrumented peer visualization for them is not yet implemented.
- The technical foundation for mapping outgoing addresses to resource names in traces is in place, but needs to be extended to handle the properties (
connectionString,Value) of the new resource types.
No existing issue or PR fully implements the feature requested in #10338, but the work is in progress and supported by recent and ongoing improvements to resource modeling and dashboard visibility.
Related issues and PRs:
Let me know if you need a more detailed summary of any specific discussion or PR!