[JitDiff X64] [jkotas] Replace Unsafe.As with Unsafe.BitCast in SpanHelpers.Fill

[MihuBot]

Job completed in 15 minutes 32 seconds (remote runner delay: 54 seconds).
dotnet/runtime#116221

Diffs

Found 83 files with textual diffs.

Summary of Code Size diffs:
(Lower is better)

Total bytes of base: 40601527
Total bytes of diff: 40601492
Total bytes of delta: -35 (-0.00 % of base)
Total relative delta: -0.14
    diff is an improvement.
    relative diff is an improvement.


Top file improvements (bytes):
         -35 : System.Private.CoreLib.dasm (-0.00 % of base)

1 total files with Code Size differences (1 improved, 0 regressed), 259 unchanged.

Top method improvements (bytes):
         -35 (-14.34 % of base) : System.Private.CoreLib.dasm - System.SpanHelpers:Fill[System.Nullable`1[int]](byref,ulong,System.Nullable`1[int]) (FullOpts)

Top method improvements (percentages):
         -35 (-14.34 % of base) : System.Private.CoreLib.dasm - System.SpanHelpers:Fill[System.Nullable`1[int]](byref,ulong,System.Nullable`1[int]) (FullOpts)

1 total methods with Code Size differences (1 improved, 0 regressed), 245465 unchanged.

--------------------------------------------------------------------------------

Artifacts:

• build-clr-checked-main.zip (87 MB)
• build-artifacts-main.zip (674 MB)
• build-clr-checked-pr.zip (87 MB)
• build-artifacts-pr.zip (675 MB)
• jit-diffs-pr.zip (135 MB)
• jit-diffs-main.zip (135 MB)
• diff-frameworks.txt (1020 B)
• ShortDiffsImprovements.md (8 KB)

[MihuBot]

Top method improvements

-35 (-14.34 % of base) - System.SpanHelpers:Fill[System.Nullable`1[int]](byref,ulong,System.Nullable`1[int])

 ; Assembly listing for method System.SpanHelpers:Fill[System.Nullable`1[int]](byref,ulong,System.Nullable`1[int]) (FullOpts)
 ; Emitting BLENDED_CODE for generic X64 + VEX + EVEX on Unix
 ; FullOpts code
 ; optimized code
 ; rbp based frame
 ; fully interruptible
 ; No PGO data
 ; 0 inlinees with PGO data; 2 single block inlinees; 1 inlinees without PGO data
 ; Final local variable assignments
 ;
-;  V00 arg0         [V00,T00] ( 18, 38   )   byref  ->  rdi         single-def
-;  V01 arg1         [V01,T07] ( 10,  6.50)    long  ->  rsi         single-def
-;  V02 arg2         [V02,T01] ( 18, 38   )  struct ( 8) rdx         single-def <System.Nullable`1[int]>
-;  V03 loc0         [V03,T04] ( 12, 20   )    long  ->  rax        
-;  V04 loc1         [V04    ] (  2,  1   )  struct ( 8) [rbp-0x08]  do-not-enreg[SF] ld-addr-op <System.Nullable`1[int]>
-;  V05 loc2         [V05,T15] (  5,  9.50)  simd32  ->  mm0         ld-addr-op <System.Numerics.Vector`1[ubyte]>
-;  V06 loc3         [V06,T06] (  5,  9.50)   byref  ->  rdi         single-def
-;  V07 loc4         [V07,T11] (  4,  2   )    long  ->  rax        
-;  V08 loc5         [V08,T08] (  2,  4.50)    long  ->  rcx        
-;  V09 loc6         [V09,T03] (  7, 21   )    long  ->  rdx        
-;* V10 loc7         [V10    ] (  0,  0   )  simd16  ->  zero-ref    <System.Runtime.Intrinsics.Vector128`1[ubyte]>
-;* V11 loc8         [V11    ] (  0,  0   )  simd32  ->  zero-ref    <System.Runtime.Intrinsics.Vector256`1[ubyte]>
-;  V12 loc9         [V12,T09] (  2,  4.50)    long  ->  rcx        
-;# V13 OutArgs      [V13    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
-;  V14 tmp1         [V14,T05] (  2, 16   )    long  ->  rax         "dup spill"
-;* V15 tmp2         [V15    ] (  0,  0   )  simd32  ->  zero-ref    ld-addr-op "NewObj constructor temp" <System.Numerics.Vector`1[ulong]>
-;* V16 tmp3         [V16    ] (  0,  0   )  simd32  ->  zero-ref   
-;* V17 tmp4         [V17    ] (  0,  0   )   ubyte  ->  zero-ref    "Inline return value spill temp"
-;* V18 tmp5         [V18    ] (  0,  0   )    long  ->  zero-ref    "Inlining Arg"
-;* V19 tmp6         [V19    ] (  0,  0   )  simd32  ->  zero-ref    "Inlining Arg" <System.Numerics.Vector`1[ulong]>
-;  V20 tmp7         [V20,T13] (  2,  1   )   ubyte  ->  [rbp-0x08]  do-not-enreg[] "field V04.hasValue (fldOffset=0x0)" P-DEP
-;  V21 tmp8         [V21,T14] (  2,  1   )     int  ->  [rbp-0x04]  do-not-enreg[] "field V04.value (fldOffset=0x4)" P-DEP
-;  V22 cse0         [V22,T02] (  9, 36   )    long  ->   r8         "CSE #01: aggressive"
-;  V23 cse1         [V23,T10] (  5,  2.50)    long  ->  rcx         "CSE #02: moderate"
-;  V24 cse2         [V24,T12] (  3,  1.50)    long  ->  rcx         "CSE #03: moderate"
+;  V00 arg0         [V00,T01] ( 18, 38   )   byref  ->  rdi         single-def
+;  V01 arg1         [V01,T06] ( 10,  6.50)    long  ->  rsi         single-def
+;* V02 arg2         [V02    ] (  0,  0   )  struct ( 8) zero-ref    do-not-enreg[SF] single-def <System.Nullable`1[int]>
+;  V03 loc0         [V03,T00] ( 23, 50   )    long  ->  rax        
+;  V04 loc1         [V04,T10] (  5,  9.50)  simd32  ->  mm0         ld-addr-op <System.Numerics.Vector`1[ubyte]>
+;  V05 loc2         [V05,T05] (  5,  9.50)   byref  ->  rdi         single-def
+;  V06 loc3         [V06,T09] (  4,  2   )    long  ->  rax        
+;  V07 loc4         [V07,T07] (  2,  4.50)    long  ->  rcx        
+;  V08 loc5         [V08,T03] (  7, 21   )    long  ->  rdx        
+;  V09 loc6         [V09,T08] (  2,  4.50)    long  ->  rcx        
+;# V10 OutArgs      [V10    ] (  1,  1   )  struct ( 0) [rsp+0x00]  do-not-enreg[XS] addr-exposed "OutgoingArgSpace" <Empty>
+;  V11 tmp1         [V11,T04] (  2, 16   )    long  ->  rax         "dup spill"
+;* V12 tmp2         [V12    ] (  0,  0   )  simd32  ->  zero-ref    ld-addr-op "NewObj constructor temp" <System.Numerics.Vector`1[ulong]>
+;* V13 tmp3         [V13    ] (  0,  0   )  simd32  ->  zero-ref   
+;* V14 tmp4         [V14    ] (  0,  0   )   ubyte  ->  zero-ref    "Inline return value spill temp"
+;* V15 tmp5         [V15    ] (  0,  0   )    long  ->  zero-ref    "Inlining Arg"
+;* V16 tmp6         [V16    ] (  0,  0   )  simd32  ->  zero-ref    "Inlining Arg" <System.Numerics.Vector`1[ulong]>
+;  V17 tmp7         [V17,T02] ( 18, 38   )    long  ->  rdx         "V02.[000..008) V02.rdx"
 ;
-; Lcl frame size = 16
+; Lcl frame size = 0
 
 G_M56207_IG01:
        push     rbp
-       sub      rsp, 16
-       lea      rbp, [rsp+0x10]
-						;; size=10 bbWeight=1 PerfScore 1.75
+       mov      rbp, rsp
+						;; size=4 bbWeight=1 PerfScore 1.25
 G_M56207_IG02:
        cmp      rsi, 4
        jae      G_M56207_IG08
 						;; size=10 bbWeight=1 PerfScore 1.25
 G_M56207_IG03:
        xor      eax, eax
        cmp      rsi, 8
        jb       SHORT G_M56207_IG05
        mov      rcx, rsi
        and      rcx, -8
-       align    [0 bytes for IG04]
-						;; size=15 bbWeight=0.50 PerfScore 1.00
+       align    [3 bytes for IG04]
+						;; size=18 bbWeight=0.50 PerfScore 1.12
 G_M56207_IG04:
-       lea      r8, [8*rax]
-       mov      qword ptr [rdi+r8], rdx
-       mov      qword ptr [rdi+r8+0x08], rdx
-       mov      qword ptr [rdi+r8+0x10], rdx
-       mov      qword ptr [rdi+r8+0x18], rdx
-       mov      qword ptr [rdi+r8+0x20], rdx
-       mov      qword ptr [rdi+r8+0x28], rdx
-       mov      qword ptr [rdi+r8+0x30], rdx
-       mov      qword ptr [rdi+r8+0x38], rdx
+       mov      qword ptr [rdi+8*rax], rdx
+       mov      qword ptr [rdi+8*rax+0x08], rdx
+       mov      qword ptr [rdi+8*rax+0x10], rdx
+       mov      qword ptr [rdi+8*rax+0x18], rdx
+       mov      qword ptr [rdi+8*rax+0x20], rdx
+       mov      qword ptr [rdi+8*rax+0x28], rdx
+       mov      qword ptr [rdi+8*rax+0x30], rdx
+       mov      qword ptr [rdi+8*rax+0x38], rdx
        add      rax, 8
        cmp      rax, rcx
        jb       SHORT G_M56207_IG04
-						;; size=56 bbWeight=4 PerfScore 40.00
+						;; size=48 bbWeight=4 PerfScore 38.00
 G_M56207_IG05:
        test     sil, 4
        je       SHORT G_M56207_IG06
-       lea      rcx, [8*rax]
-       mov      qword ptr [rdi+rcx], rdx
-       mov      qword ptr [rdi+rcx+0x08], rdx
-       mov      qword ptr [rdi+rcx+0x10], rdx
-       mov      qword ptr [rdi+rcx+0x18], rdx
+       mov      qword ptr [rdi+8*rax], rdx
+       mov      qword ptr [rdi+8*rax+0x08], rdx
+       mov      qword ptr [rdi+8*rax+0x10], rdx
+       mov      qword ptr [rdi+8*rax+0x18], rdx
        add      rax, 4
-						;; size=37 bbWeight=0.50 PerfScore 3.00
+						;; size=29 bbWeight=0.50 PerfScore 2.75
 G_M56207_IG06:
        test     sil, 2
        je       SHORT G_M56207_IG07
-       lea      rcx, [8*rax]
-       mov      qword ptr [rdi+rcx], rdx
-       mov      qword ptr [rdi+rcx+0x08], rdx
+       mov      qword ptr [rdi+8*rax], rdx
+       mov      qword ptr [rdi+8*rax+0x08], rdx
        add      rax, 2
-						;; size=27 bbWeight=0.50 PerfScore 2.00
+						;; size=19 bbWeight=0.50 PerfScore 1.75
 G_M56207_IG07:
        test     sil, 1
        je       SHORT G_M56207_IG12
        mov      qword ptr [rdi+8*rax], rdx
        jmp      SHORT G_M56207_IG12
        align    [0 bytes for IG09]
 						;; size=12 bbWeight=0.50 PerfScore 2.12
 G_M56207_IG08:
-       mov      qword ptr [rbp-0x08], rdx
-       vpbroadcastq ymm0, qword ptr [rbp-0x08]
+       vpbroadcastq ymm0, rdx
        lea      rax, [8*rsi]
        mov      rcx, rax
        and      rcx, -64
        xor      edx, edx
        cmp      rsi, 8
        jb       SHORT G_M56207_IG10
-						;; size=33 bbWeight=0.50 PerfScore 3.75
+						;; size=29 bbWeight=0.50 PerfScore 2.25
 G_M56207_IG09:
        vmovups  ymmword ptr [rdi+rdx], ymm0
        vmovups  ymmword ptr [rdi+rdx+0x20], ymm0
        add      rdx, 64
        cmp      rdx, rcx
        jb       SHORT G_M56207_IG09
 						;; size=20 bbWeight=4 PerfScore 22.00
 G_M56207_IG10:
        test     al, 32
        je       SHORT G_M56207_IG11
        vmovups  ymmword ptr [rdi+rdx], ymm0
 						;; size=9 bbWeight=0.50 PerfScore 1.62
 G_M56207_IG11:
        vmovups  ymmword ptr [rdi+rax-0x20], ymm0
 						;; size=6 bbWeight=0.50 PerfScore 1.00
 G_M56207_IG12:
        vzeroupper 
-       add      rsp, 16
        pop      rbp
        ret      
-						;; size=9 bbWeight=1 PerfScore 2.75
+						;; size=5 bbWeight=1 PerfScore 2.50
 
-; Total bytes of code 244, prolog size 10, PerfScore 82.25, instruction count 63, allocated bytes for code 244 (MethodHash=b4fe2470) for method System.SpanHelpers:Fill[System.Nullable`1[int]](byref,ulong,System.Nullable`1[int]) (FullOpts)
+; Total bytes of code 209, prolog size 4, PerfScore 77.62, instruction count 57, allocated bytes for code 209 (MethodHash=b4fe2470) for method System.SpanHelpers:Fill[System.Nullable`1[int]](byref,ulong,System.Nullable`1[int]) (FullOpts)
 ; ============================================================

[MihuBot]

@MihaZupan