This repository was archived by the owner on Nov 11, 2021. It is now read-only.
Make css-grid example more semantic#421
Open
vansosnin wants to merge 2 commits intoMicrosoftEdge:masterfrom
Open
Make css-grid example more semantic#421vansosnin wants to merge 2 commits intoMicrosoftEdge:masterfrom
vansosnin wants to merge 2 commits intoMicrosoftEdge:masterfrom
Conversation
Contributor
|
I'm pretty sure @gregwhitworth is the one who wrote the code for this. |
Contributor
|
Sorry for the delay on this and thank you for taking the time @vansosnin You have changed the name computation by putting the Please at-mention me upon completion so I get an email about the change. Thank you! |
Author
|
@gregwhitworth thanks, and it's done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Wraps images into buttons to better interactivity using the keyboard.
Requirements
.github/ACCESSIBILITY_REQS.md)..github/CSS_STYLE_REQS.md).npm run lint:css -- demoDirectoryName/**/*.cssandnpm run lint:js -- demoDirectoryName/**/*.js, and have fixed the errors.