Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the descriptions of throttling rate to match the result of sample commands in New-NetQosPolicy #3701

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Tamrin007
Copy link

PR Summary

The throttling rate shows in bits, not bytes.
#2559 corrects the result of the sample commands, but the descriptions are still incorrect.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

Copy link
Contributor

Learn Build status updates of commit 0d463e3:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (winserver2012-ps)
docset/winserver2012r2-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit b46927f:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (winserver2012-ps)
docset/winserver2012r2-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@Tamrin007 Tamrin007 force-pushed the fix-incorrect-expanation-about-throttle-rate-limitation-unit branch from b46927f to 9e21323 Compare October 9, 2024 01:37
Copy link
Contributor

Learn Build status updates of commit 9e21323:

✅ Validation status: passed

File Status Preview URL Details
docset/winserver2012-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (winserver2012-ps)
docset/winserver2012r2-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (winserver2012r2-ps)
docset/winserver2016-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (WindowsServer2016-ps)
docset/winserver2019-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (WindowsServer2019-ps)
docset/winserver2022-ps/netqos/New-NetQosPolicy.md ✅Succeeded View (WindowsServer2022-ps)

For more details, please refer to the build report.

For any questions, please:

@Tamrin007
Copy link
Author

Hi @get-itips @msbemba @scanum, thank you for taking the time to review and work on this PR. It looks like all reviews and checks have passed. Are there any additional actions required before this request can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants