Update CustomWebUI interface docs with security related caution message#721
Conversation
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit a2f68c7: 💡 Validation status: suggestions
msal-dotnet-articles/advanced/extensibility-points.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 93ae232: 💡 Validation status: suggestions
msal-dotnet-articles/advanced/extensibility-points.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
dotnet/xml/Microsoft.Identity.Client.Extensibility/ICustomWebUi.xml
Outdated
Show resolved
Hide resolved
dotnet/xml/Microsoft.Identity.Client.Extensibility/ICustomWebUi.xml
Outdated
Show resolved
Hide resolved
dotnet/xml/Microsoft.Identity.Client.Extensibility/ICustomWebUi.xml
Outdated
Show resolved
Hide resolved
|
Hi @ashok672 @iulico-1 , thanks for the updates here. Just had a quick look, hese are great updates. One callout, though: I wouldn’t recommend editing the XML files directly in this repo, since they’re auto-generated from the SDK source code. Any changes to the XML docs should be made in the corresponding file in the SDK source repo instead; otherwise, they’ll be overwritten the next time CI regenerates and updates the reference content. As-is, these updates will get published and show up in the docs, but only until the next refresh auto-generates XML files from source; and everything gets overwritten. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 02f2cb9: 💡 Validation status: suggestions
msal-dotnet-articles/advanced/extensibility-points.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit 8b69f1f: 💡 Validation status: suggestions
msal-dotnet-articles/advanced/extensibility-points.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 and severity-2 issues. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
|
Learn Build status updates of commit e45af06: 💡 Validation status: suggestions
msal-dotnet-articles/advanced/extensibility-points.md
For more details, please refer to the build report. Note: Your PR may contain errors or warnings or suggestions unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them. |
Thanks for the review and it was helpful. I was not aware of this mechanism. I have updated the MSAL. NET documenation with the same change. Here is the PR for that |
Added CAUTION alerts to ICustomWebUi documentation warning developers about security risks when using native client redirect URIs (
http://localhostandhttps://login.microsoftonline.com/common/oauth2/nativeclient) with custom web UI implementations. The approach is no longer functional due to eSTS redirecting within 3 seconds to clear the authorization code from the URL, breaking manual code extraction flows. Developers are directed to use Broker authentication (WAM) or embedded browser flow recommended alternatives.