-
Notifications
You must be signed in to change notification settings - Fork 810
Document maximum regex based claims transforms and related errors #1785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Jackson-Woods
commented
Oct 8, 2025
- Documents max of 20 regex based claims transforms on SAML and JWT doc
- Add line for customer-reported error code 501631, plus related error code 501632
Add a note for maximum 20 regex based claims transformations.
Added other STS error codes for regex claims transform
Added line stating 20 maximum regex based claims transforms to JWT claims customization doc.
@Jackson-Woods : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change. |
Learn Build status updates of commit 0e18d2d: ✅ Validation status: passed
For more details, please refer to the build report. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR documents the maximum limit for regex-based claims transformations and adds error codes for related configuration issues. The changes improve user understanding of system limitations and error handling.
- Added documentation for the 20 regex replacement limit in both SAML and JWT claims transformation sections
- Included two new error codes (501631, 501632) for regex transformation failures
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
docs/identity-platform/saml-claims-customization.md | Added documentation for 20 regex replacement limit |
docs/identity-platform/jwt-claims-customization.md | Added documentation for 20 regex replacement limit |
docs/identity-platform/reference-error-codes.md | Added new error codes 501631 and 501632 for regex transformation issues |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Hi @Jackson-Woods - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR open for review and merge, but would you make future content updates in the private repo? Thank you! Can you review the proposed changes? IMPORTANT: When the changes are ready for publication, adding a #label:"aq-pr-triaged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving for the changes to the error code documentation. I do not own the claims transformation documentation, so additional approval is required.
@cilwerner or @OwenRichards1 can one of you please check this PR and sign off for merge? |
Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @cilwerner, @OwenRichards1 |
#hold-off |
Fix typo Co-authored-by: Copilot <[email protected]>
Fixed the typo @OwenRichards1, thanks for catching it. |
Learn Build status updates of commit 0fd4bfd: ✅ Validation status: passed
For more details, please refer to the build report. |
@OwenRichards1 is this ok to merge now? |
#sign-off |