Skip to content

Conversation

Jackson-Woods
Copy link
Contributor

  • Documents max of 20 regex based claims transforms on SAML and JWT doc
  • Add line for customer-reported error code 501631, plus related error code 501632

Add a note for maximum 20 regex based claims transformations.
Added other STS error codes for regex claims transform
Added line stating 20 maximum regex based claims transforms to JWT claims customization doc.
Copy link
Contributor

@Jackson-Woods : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Learn Build status updates of commit 0e18d2d:

✅ Validation status: passed

File Status Preview URL Details
docs/identity-platform/jwt-claims-customization.md ✅Succeeded
docs/identity-platform/reference-error-codes.md ✅Succeeded
docs/identity-platform/saml-claims-customization.md ✅Succeeded

For more details, please refer to the build report.

@ttorble ttorble requested a review from Copilot October 8, 2025 14:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR documents the maximum limit for regex-based claims transformations and adds error codes for related configuration issues. The changes improve user understanding of system limitations and error handling.

  • Added documentation for the 20 regex replacement limit in both SAML and JWT claims transformation sections
  • Included two new error codes (501631, 501632) for regex transformation failures

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docs/identity-platform/saml-claims-customization.md Added documentation for 20 regex replacement limit
docs/identity-platform/jwt-claims-customization.md Added documentation for 20 regex replacement limit
docs/identity-platform/reference-error-codes.md Added new error codes 501631 and 501632 for regex transformation issues

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ttorble
Copy link
Contributor

ttorble commented Oct 8, 2025

Hi @Jackson-Woods - This pull request was opened in the public repo. PMs should work in the private repo, per the Microsoft Docs contributor guide. We can keep this PR open for review and merge, but would you make future content updates in the private repo? Thank you!

@cilwerner and @OwenRichards1

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

Copy link
Contributor

@nickludwig nickludwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for the changes to the error code documentation. I do not own the claims transformation documentation, so additional approval is required.

@Jackson-Woods
Copy link
Contributor Author

Jackson-Woods commented Oct 13, 2025

@cilwerner or @OwenRichards1 can one of you please check this PR and sign off for merge?

Copy link
Contributor

Invalid command: '#sign-off'. Only the assigned author of one or more file in this PR can sign off. @cilwerner, @OwenRichards1

@OwenRichards1
Copy link
Contributor

#hold-off

@Jackson-Woods
Copy link
Contributor Author

Fixed the typo @OwenRichards1, thanks for catching it.

Copy link
Contributor

Learn Build status updates of commit 0fd4bfd:

✅ Validation status: passed

File Status Preview URL Details
docs/identity-platform/jwt-claims-customization.md ✅Succeeded
docs/identity-platform/reference-error-codes.md ✅Succeeded
docs/identity-platform/saml-claims-customization.md ✅Succeeded

For more details, please refer to the build report.

@Jackson-Woods
Copy link
Contributor Author

@OwenRichards1 is this ok to merge now?

@OwenRichards1
Copy link
Contributor

#sign-off

@v-dirichards v-dirichards merged commit 8d6a375 into MicrosoftDocs:main Oct 21, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants